Repository navigation
Conversation
Co-authored-by: tmplummer <16110870+tmplummer@users.noreply.github.com>
tmplummer
requested review from
bryan-harter and
laspsandoval
and
a balanced review from Copilot
October 1, 2026 16:50
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new regex accepts filenames containing trailing content after the .bc extension.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds support for IMAP-Lo pivot attitude kernels throughout validation and processing.
Changes:
- Adds filename parsing, metadata extraction, and CK routing.
- Exposes repointing IDs and updates CLI query help.
- Adds parsing, validation, path, and
SPICEInputtests.
| File | Description |
|---|---|
imap_data_access/file_validation.py |
Registers and parses Lo pivot kernels. |
imap_data_access/cli.py |
Documents the new query type. |
tests/test_file_validation.py |
Tests parsing and malformed filenames. |
tests/test_processing_input.py |
Tests SPICEInput integration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
|
You will need to update sds-data-manager, spice_utilities.py. |
laspsandoval
approved these changes
Oct 1, 2026
| return components | ||
|
|
||
| @staticmethod | ||
| def extract_filename_components(filename: Path | str) -> dict | None: |
tmplummer
commented
Oct 1, 2026
tmplummer
merged commit Oct 1, 2026
266d623
into
IMAP-Science-Operations-Center:main
16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

imap_processing generates SPICE attitude kernels for the IMAP-Lo pivot platform (IMAP_LO frame, -43101). This PR enables imap-data-access to recognize, validate, parse, and serve these kernels with the new
imap_lopivotfile type.Changes
File validation and metadata extraction
imap_lopivot-repoint#####_YYYY_DOY_YYYY_DOY_NNN.bcformatimap/spice/ck/directory (attitude kernel subdirectory)repoint00125)Type system
imap_lopivot→lo_pivot_attitudemappinglo_pivot_attitudein directory structure mappingCLI and discovery
--typehelp text to includelo_pivot_attitudeas a valid query typeExample filename parsing
Testing
lo_pivotpattern matches the filename formatSPICEInputaccepts lo_pivot filesFixes #357