Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection_class as input param #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

botzill
Copy link

@botzill botzill commented Oct 20, 2021

Added custom connection_class for the use cases when you want to configure custom connection, like custom proxies or other params.

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #1 (1c38699) into master (a7993c1) will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   81.35%   81.58%   +0.23%     
==========================================
  Files           2        2              
  Lines         236      239       +3     
  Branches       42       42              
==========================================
+ Hits          192      195       +3     
  Misses         24       24              
  Partials       20       20              
Impacted Files Coverage Δ
elasticecslogging/handlers.py 81.03% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7993c1...1c38699. Read the comment docs.

@tommycahir
Copy link

@botzill It should probably be noted that 'RequestsHttpConnection' was removed from 'elasticsearch' and is replaced with RequestsHttpNode from elastic_transport elastic/elasticsearch-py#1778 (comment) so you may need to set the default to RequestsHttpNode and hope it gets merged..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants