dz#29
Open
Kislota1 wants to merge 3 commits into
Open
Conversation
alexthvest
reviewed
Oct 19, 2021
Comment on lines
+5
to
+13
| interface IHasInfo | ||
| { | ||
| void ShowInfo(); | ||
| } | ||
| interface IWeapon : IHasInfo | ||
| { | ||
| void Fire(); | ||
| int Damage { get; } | ||
| } |
There was a problem hiding this comment.
One file - one class/interface/enum
Contributor
There was a problem hiding this comment.
and always so - only one there - 1 file per 1 class
|
|
||
| class Gun : Weapon | ||
| { | ||
| public override int Damage { get { return 10; } } |
There was a problem hiding this comment.
Suggested change
| public override int Damage { get { return 10; } } | |
| public override int Damage => 10; |
| } | ||
| } | ||
|
|
||
| class Program |
There was a problem hiding this comment.
Please always specify access modifier
jskonst
reviewed
Nov 8, 2021
Comment on lines
+1
to
+8
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>net5.0</TargetFramework> | ||
| </PropertyGroup> | ||
|
|
||
| </Project> |
Contributor
There was a problem hiding this comment.
Move all Player logic to CourceApp project (may place code in the subfolder) Or - add stylecop and test's connection to the project
jskonst
reviewed
Nov 20, 2021
| </ItemGroup> | ||
|
|
||
| </Project> | ||
| <Project Sdk="Microsoft.NET.Sdk"> |
Contributor
There was a problem hiding this comment.
why this file shown as changed?
configure you gitattributes to fit lineendings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.