Nikita rybkin#35
Open
Nikrybkin wants to merge 8 commits into
Open
Conversation
jskonst
reviewed
Nov 8, 2021
| Assert.True(true); | ||
| } | ||
|
|
||
| [Fact] |
Contributor
There was a problem hiding this comment.
Please - use Inline data to check multiple cases
jskonst
reviewed
Nov 8, 2021
| public double[] TaskA(double xn, double xk, double dx) | ||
| { | ||
| int g = (int)(((xk - xn) / dx) + 1); | ||
| double[] results = new double[g]; |
jskonst
reviewed
Nov 8, 2021
| DateOfDeath = dateOfDeath; | ||
| } | ||
|
|
||
| public string Pig |
Contributor
There was a problem hiding this comment.
Pig here sinonym to the name? if it does not do anything in get and set - then simply use Pig {get; set;}
jskonst
requested changes
Dec 6, 2021
Contributor
jskonst
left a comment
jskonst
left a comment
There was a problem hiding this comment.
Куда делся github actions? Почему проверки не запускаются?
Author
jskonst
reviewed
Dec 11, 2021
| @@ -0,0 +1,76 @@ | |||
| namespace CourseApp | |||
| { | |||
| public class PigAndSalo | |||
Contributor
There was a problem hiding this comment.
why it's not extends Pig class?
jskonst
reviewed
Dec 11, 2021
| using System; | ||
|
|
||
| using System; | ||
| /* using System.Collections.Generic;*/ |
Contributor
There was a problem hiding this comment.
Please - remove all commented code
jskonst
reviewed
Dec 11, 2021
| { | ||
| int lard = Lard; | ||
| Lard = 0; | ||
| return $"{Name} зарезана\nПолучено {lard} сала\n"; |
jskonst
reviewed
Dec 11, 2021
| return $"{Name} зарезана\nПолучено {lard} сала\n"; | ||
| } | ||
|
|
||
| public override string MakePhrase(string[] phraseArray) |
Contributor
There was a problem hiding this comment.
should this one belong to Pig class?
jskonst
reviewed
Dec 11, 2021
| Pig pigTwo = new Pig("Бычок", 9, 99); | ||
| Bull boarOne = new Bull("Бычок 1", 1, 5, 7); | ||
| Bull boarTwo = new Bull("Бычок 2", 3, 2, 8); | ||
| Animals[] animals = new Animals[] { pigOne, pigTwo, boarOne, boarTwo }; |
Contributor
There was a problem hiding this comment.
Can we add some common method for all Animals and call it in the loop?
jskonst
reviewed
Dec 11, 2021
Comment on lines
+30
to
+35
| public override string Died() | ||
| { | ||
| int lard = Lard; | ||
| Lard = 0; | ||
| return $"{Name} убит\nПолучено {lard} сала\n"; | ||
| } |
jskonst
reviewed
Dec 11, 2021
| namespace CourseApp | ||
| { | ||
| using System; | ||
| /* using System.Collections.Generic;*/ |
jskonst
reviewed
Dec 11, 2021
Comment on lines
+101
to
+111
| public override string ToString() | ||
| { | ||
| if (lard == 0) | ||
| { | ||
| return $"{Name} Без сала\n"; | ||
| } | ||
| else | ||
| { | ||
| return $"Из {Name} можно получить {Lard} сала\n"; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Прям с любого животного? что-то не так с абстракциями
jskonst
reviewed
Dec 11, 2021
|
|
||
| public abstract string Died(); | ||
|
|
||
| public abstract string MakePhrase(string[] phraseArray); |
Contributor
There was a problem hiding this comment.
Этот метод тут не нужен (да и в дочерних тоже)
jskonst
reviewed
Dec 11, 2021
Comment on lines
+50
to
+57
| if (value < 0) | ||
| { | ||
| weight = 0; | ||
| } | ||
| else | ||
| { | ||
| weight = value; | ||
| } |
Contributor
There was a problem hiding this comment.
Let's throw exception here
jskonst
reviewed
Dec 11, 2021
Comment on lines
+12
to
+33
| public Animals() | ||
| : this("неизвестного животного", 10, 12, 13) | ||
| { | ||
| } | ||
|
|
||
| public Animals(string name, int weight) | ||
| : this(name, weight, 0, 0) | ||
| { | ||
| } | ||
|
|
||
| public Animals(string name, int weight, int lard) | ||
| : this(name, weight, 0, lard) | ||
| { | ||
| } | ||
|
|
||
| public Animals(string name, int weight, int age, int lard) | ||
| { | ||
| Name = name; | ||
| Lard = lard; | ||
| Age = age; | ||
| Weight = weight; | ||
| } |
Contributor
There was a problem hiding this comment.
Do we really need that much of constructors?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.