Trofimov Maxim#8
Open
mak271 wants to merge 8 commits into
Open
Conversation
Author
|
first travail labo |
Вроде багов нет(но полностью уверенным в этом никогда нельзя быть). Синтаксис ещё надо доработать.
На новом кону абилки не обнулялись не переставали действовать. Исправил это.
jskonst
requested changes
May 25, 2022
Comment on lines
+7
to
+12
| self.health = round(random.random() * 100) | ||
| self.power = round(random.random() * 50) | ||
| self.damage = self.power | ||
| self.class_name = "Паладин" | ||
| self.ability_name = "Удар возмездия" | ||
| self.is_ability_activated = False |
Contributor
There was a problem hiding this comment.
инициализационные параметры лучше передавать извне в функцию инициализации
|
|
||
| class Paladin(Player): | ||
|
|
||
| def __init__(self): |
Contributor
There was a problem hiding this comment.
Suggested change
| def __init__(self): | |
| def __init__(self, health, power, damage, class_name, name....): |
| self.power = round(random.random() * 50) | ||
| self.damage = self.power | ||
| self.class_name = "Паладин" | ||
| self.ability_name = "Удар возмездия" |
Contributor
There was a problem hiding this comment.
Вот тут лучше бы хранить массив способностей - а каждая способность - это отдельный объект
|
|
||
| is_use_ability = random.choice([True, False]) | ||
| if is_use_ability: | ||
| damage = player_2.special_ability() |
Contributor
There was a problem hiding this comment.
решение использолвать или не использовать Ability - добавьте персонажу
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first update README