Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request to trigger Action that calls Vester to visually test the branch attempting to merge, with visually altering changes #5

Open
wants to merge 1 commit into
base: vester_visual_testing
Choose a base branch
from

Conversation

IVAN-MK7
Copy link
Owner

It's expected to warn that the changes of this branch alter the visuals of the resulting application, therefore vester_visual_testing's visuals will be altered in case of a merge with visually_altering_changes.

@IVAN-MK7
Copy link
Owner Author

IVAN-MK7 commented Mar 17, 2023

As expected Vester warns that this branch's changes alter the visuals of the resulting application, in this example case the underline of Hyperlinks is missing when hovered. Resulting images taken from Vester API page

image

The GitHub Action result:
image
text:Token is valid, process executed, scan NOT passed. Vester: "step_1_Hyperlink_underline's screenshot scan failed to pass, attempted to scan for 6 seconds with no match.". Task id: 1. Get faulty step's images and info json with a GET http request to 'https://mk7.tech:13117/Vester/API/' + Token + '/get_failed_scan_images', or by visiting 'https://mk7.tech/Vester/API'. Ended success:false

@IVAN-MK7 IVAN-MK7 changed the title Pull request to trigger Action that calls Vester to visually test the branch attempting to merge Pull request to trigger Action that calls Vester to visually test the branch attempting to merge, with visually altering changes Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant