Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow passing null or undefined as response body #27

Merged
merged 1 commit into from
Oct 28, 2024
Merged

feat: allow passing null or undefined as response body #27

merged 1 commit into from
Oct 28, 2024

Conversation

dirkluijk
Copy link
Collaborator

@dirkluijk dirkluijk commented Oct 26, 2024 •
edited
Loading

Fixes #25

@dirkluijk dirkluijk mentioned this pull request Oct 26, 2024
Closed
@dirkluijk dirkluijk requested a review from IanVS October 28, 2024 09:03
@dirkluijk dirkluijk linked an issue Oct 28, 2024 that may be closed by this pull request
Invalid response status after update to 0.4.0 #25
Closed
@IanVS
Copy link
Owner

IanVS commented Oct 28, 2024

I can also construct a Response in Chrome using new Response(undefined, {status: 204}), should that also be allowed here?

@dirkluijk dirkluijk force-pushed the feat-allow-nullable-response-body branch from b9ae119 to 501e571 Compare October 28, 2024 12:56
@dirkluijk
Copy link
Collaborator Author

Good idea, fixed!

@dirkluijk dirkluijk force-pushed the feat-allow-nullable-response-body branch from 501e571 to 8623768 Compare October 28, 2024 12:58
@dirkluijk dirkluijk changed the title feat: allow passing null as response body feat: allow passing null or undefined as response body Oct 28, 2024
Base automatically changed from feat-flexible-overloads to main October 28, 2024 13:27
@IanVS
Copy link
Owner

IanVS commented Oct 28, 2024

Mind handling the conflict here, @dirkluijk, and then I will merge and release 0.4.1?

@dirkluijk dirkluijk force-pushed the feat-allow-nullable-response-body branch from 8623768 to 8f80669 Compare October 28, 2024 13:49
@dirkluijk
Copy link
Collaborator Author

dirkluijk commented Oct 28, 2024 •
edited
Loading

Done!

@dirkluijk dirkluijk merged commit 83816e5 into main Oct 28, 2024
3 checks passed
@dirkluijk dirkluijk deleted the feat-allow-nullable-response-body branch October 28, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanVS IanVS Awaiting requested review from IanVS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid response status after update to 0.4.0
2 participants
@dirkluijk @IanVS