Fix ruby 3 error when keyword argument is passed #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lulalala
commented
Sep 4, 2022
|
|
||
| # Default the arguments to an empty array. Otherwise in Ruby 1.8 | ||
| # a `nil` args will actually pass `nil` into the class. Not what | ||
| # we want! | ||
| args ||= [] | ||
| kwargs ||= {} |
There was a problem hiding this comment.
I only added this line because runner_spec omits args, and only passes in klass. This wouldn't happen if builder is used.
However, if we no longer support Ruby 1.8, I wonder if we should remove this block all together, and amend runner_spec instead?
|
Hi @lilobase would you know whom I can ask for review please? Thanks. |
|
Hello, sorry I didn't see your PR, many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby 3, keyword arguments must be splat separately (using double splat):
https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
This would mean the gem will no longer be compatible to Ruby < 2.0