ElasticsearchWriter#Pause(): lock m_DataBufferMutex during Flush()

just to be sure regarding race conditions.
Icinga · Jun 30, 2023 · 076eb59 · 076eb59
1 parent d5e6ece
commit 076eb59
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/lib/perfdata/elasticsearchwriter.cpp b/lib/perfdata/elasticsearchwriter.cpp
@@ -119,7 +119,11 @@ void ElasticsearchWriter::Pause()
 
 	m_FlushTimer->Stop(true);
 	m_WorkQueue.Join();
-	Flush();
+
+	{
+		std::unique_lock<std::mutex> lock (m_DataBufferMutex);
+		Flush();
+	}
 
 	Log(LogInformation, "ElasticsearchWriter")
 		<< "'" << GetName() << "' paused.";