Skip to content

Commit

Permalink
PluginCheckTask::ProcessFinishedHandler(): warn about exit codes outs…
Browse files Browse the repository at this point in the history
…ide 0..3

in the plugin output as well, in addition to the warning log.
  • Loading branch information
Al2Klimov committed Sep 17, 2024
1 parent 0605577 commit 1446139
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions lib/methods/pluginchecktask.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#include "base/utility.hpp"
#include "base/process.hpp"
#include "base/convert.hpp"
#include <sstream>

using namespace icinga;

Expand Down Expand Up @@ -66,15 +67,22 @@ void PluginCheckTask::ProcessFinishedHandler(const Checkable::Ptr& checkable, co
Checkable::CurrentConcurrentChecks.fetch_sub(1);
Checkable::DecreasePendingChecks();

String output = pr.Output.Trim();

if (pr.ExitStatus > 3) {
Process::Arguments parguments = Process::PrepareCommand(commandLine);
Log(LogWarning, "PluginCheckTask")
<< "Check command for object '" << checkable->GetName() << "' (PID: " << pr.PID
<< ", arguments: " << Process::PrettyPrintArguments(parguments) << ") terminated with exit code "
<< pr.ExitStatus << ", output: " << pr.Output;
}

String output = pr.Output.Trim();
std::stringstream crOutput;

crOutput << "<Terminated with exit code " << pr.ExitStatus
<< " (0x" << std::noshowbase << std::hex << std::uppercase << pr.ExitStatus << ").>";

output += crOutput.str();
}

std::pair<String, String> co = PluginUtility::ParseCheckOutput(output);
cr->SetCommand(commandLine);
Expand Down

0 comments on commit 1446139

Please sign in to comment.