Skip to content

Commit

Permalink
check_systemd: Fix executable name by dropping .py
Browse files Browse the repository at this point in the history
The executable name for check_systemd's dropped the `.py` suffix for
version 2.0.3[0], released in April 2019[1]. However, the old name is
still being referenced, both in documentation as well as in the ITL's
CheckCommand's command, making it unusable.

Closes #9547.

[0]: Josef-Friedrich/check_systemd@v2.0.2...v2.0.3#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
[1]: https://github.com/Josef-Friedrich/check_systemd/releases/tag/v2.0.3
  • Loading branch information
oxzi committed Apr 3, 2024
1 parent 9e31b8b commit c9f9157
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions doc/03-monitoring-basics.md
Original file line number Diff line number Diff line change
Expand Up @@ -2135,7 +2135,7 @@ In order to find out about the command argument, call the plugin's help
or consult the README.

```
./check_systemd.py --help
./check_systemd --help
...
Expand Down Expand Up @@ -2194,7 +2194,7 @@ With the [example above](03-monitoring-basics.md#command-arguments-value),
inspect the parameter's help text.

```
./check_systemd.py --help
./check_systemd --help
...
Expand Down
8 changes: 4 additions & 4 deletions doc/05-service-monitoring.md
Original file line number Diff line number Diff line change
Expand Up @@ -281,10 +281,10 @@ that [it works](05-service-monitoring.md#service-monitoring-plugins-it-works). T
`--help` parameter to see the actual parameters (docs might be outdated).

```
./check_systemd.py --help
./check_systemd --help
usage: check_systemd.py [-h] [-c SECONDS] [-e UNIT | -u UNIT] [-v] [-V]
[-w SECONDS]
usage: check_systemd [-h] [-c SECONDS] [-e UNIT | -u UNIT] [-v] [-V]
[-w SECONDS]
...
Expand Down Expand Up @@ -319,7 +319,7 @@ Start with the basic plugin call without any parameters.

```
object CheckCommand "systemd" { // Plugin name without 'check_' prefix
command = [ PluginContribDir + "/check_systemd.py" ] // Use the 'PluginContribDir' constant, see the contributed ITL commands
command = [ PluginContribDir + "/check_systemd" ] // Use the 'PluginContribDir' constant, see the contributed ITL commands
}
```

Expand Down
2 changes: 1 addition & 1 deletion doc/10-icinga-template-library.md
Original file line number Diff line number Diff line change
Expand Up @@ -3652,7 +3652,7 @@ iostat\_cwrite | **Required.** Critical threshold for KB/s writes (default: 200)

#### systemd <a id="plugin-contrib-command-systemd"></a>

The [check_systemd.py](https://github.com/Josef-Friedrich/check_systemd) plugin
The [check_systemd](https://github.com/Josef-Friedrich/check_systemd) plugin
will report a degraded system to your monitoring solution. It requires only the [nagiosplugin](https://nagiosplugin.readthedocs.io/en/stable) library.

Custom variables passed as [command parameters](03-monitoring-basics.md#command-passing-parameters):
Expand Down
2 changes: 1 addition & 1 deletion itl/plugins-contrib.d/systemd.conf
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* Icinga 2 | (c) 2012 Icinga GmbH | GPLv2+ */

object CheckCommand "systemd" {
command = [ PluginContribDir + "/check_systemd.py" ]
command = [ PluginContribDir + "/check_systemd" ]

arguments = {
"--unit" = {
Expand Down

0 comments on commit c9f9157

Please sign in to comment.