Stream#Read(): remove de facto unused param allow_partial #9736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al2Klimov
force-pushed
the
stream-read-allow_partial
branch
from
38eb45b
to
e1f9bc9
Compare
The only caller passes true, so no one forbids partial reads (even implicitly). All usages in the implementation just assert it being true (allowed).
Al2Klimov
force-pushed
the
stream-read-allow_partial
branch
from
e1f9bc9
to
1308ad6
Compare
yhabteab
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only caller passes true, so no one forbids partial reads (even implicitly). All usages in the implementation just assert it being true (allowed).