Fix wrong PerfData normalization

[Welrub]

refs #9634

[cla-bot]

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @Welrub

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

• If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

[Welrub]

done

[bobapple]

@cla-bot check

[Welrub]

signed27.06.2023, 16:02, "Blerim Sheqa" ***@***.***>: @cla-bot check —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[julianbrost]

First of all, thanks for you interest in contributing to Icinga.

This change makes the test cases fail as it will always render all trailing ;, even if they aren't needed. You can find these tests in test/icinga-perfdata.cpp. I think it would be nicer if the returned string would be kept minimal, i.e. remove ; at the end if it's not required (something the old code tried, but not quite correctly).

It would also be nice if you could add a test case for the problem you're fixing here. (Note: if you're adding an entirely new test function, it has to be added to test/CMakeLists.txt as well.)