Added cross-browser fullscreen behaviour #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiLazarova
added
the
✅ status: verified
mddragnev
requested changes
Dec 5, 2025
Member
mddragnev
left a comment
mddragnev
left a comment
There was a problem hiding this comment.
Two more things:
1.
Entering full screen mode there is an additional scrollbar.
- All the checks whether window/document is defined are redundant here because we are using client side code in the entire file. Event if we migrate this project to SSR we should either refactor the whole file or mark it as
'use client'. However, this is something that I can live with so just FYI
… splitting fullscreen/useEffect logic
mddragnev
requested changes
Dec 10, 2025
mddragnev
reviewed
Dec 10, 2025
mddragnev
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: IgniteUI/angular-grid-examples#147