MonoGame & FNA sample upgrade #518
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable docking support. * FNA fixes. * Minor code cleanups.
…ecause some MonoGame bug.
* Only set effect name if it's empty, so we don't string interpolate unnecessarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's good to dispose ImGuiRenderer when unloading content.
For example if the game use multiple game states which unload and loads content.
Also if you instantiated ImGuiRenderer again there would be multiple event handlers for text inputs, so I removed those in the Dispose too.
Enabled docking in BeforeLayout, otherwise you would get an cimgui assert error when you tried to use the docking feature.
Did some minor code cleanups.