Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find frames per track #65

Merged
merged 19 commits into from
Dec 20, 2024
Merged

Find frames per track #65

merged 19 commits into from
Dec 20, 2024

Conversation

zhong-al
Copy link
Collaborator

Resolves #64

@zhong-al zhong-al requested a review from egrace479 October 16, 2024 15:14
egrace479
egrace479 reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@egrace479 egrace479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing on consistency.

@zhong-al @egrace479
Apply suggestions from code review
df3b7ba 
Co-authored-by: Elizabeth Campolongo <[email protected]>
@zhong-al zhong-al requested a review from egrace479 November 13, 2024 20:06
egrace479
egrace479 reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@egrace479 egrace479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test to catch the bug (#64)?

@zhong-al
Copy link
Collaborator Author

Can you add a test to catch the bug (#64)?

kabr-tools/tests/test_miniscene2behavior.py

Line 186 in aaf079e

def test_nonmatching_tracks(self, video_capture, process_cv2_inputs):
from #85 catches this bug. Should I add that test to this PR?

@zhong-al zhong-al requested a review from egrace479 December 13, 2024 20:50
@egrace479
Copy link
Member

Can you add a test to catch the bug (#64)?

kabr-tools/tests/test_miniscene2behavior.py

Line 186 in aaf079e

def test_nonmatching_tracks(self, video_capture, process_cv2_inputs):

from #85 catches this bug. Should I add that test to this PR?

It would fit better in this PR with the fix.

@zhong-al zhong-al merged commit babcc3b into master Dec 20, 2024
1 check passed
@zhong-al zhong-al deleted the bug/miniscene2behavior branch December 20, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egrace479 egrace479 egrace479 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse frames per track
2 participants
@zhong-al @egrace479