Skip to content

feat: FlashMintExecutor#1

Merged
ckoopmann merged 30 commits intomainfrom
flash-mint-executor
Feb 23, 2025
Merged

feat: FlashMintExecutor#1
ckoopmann merged 30 commits intomainfrom
flash-mint-executor

Conversation

@pblivin0x
Copy link
Contributor

@pblivin0x pblivin0x commented Feb 13, 2025

To Do

  • Add unit tests for reactorCallback(), execute(), executeBatch() in test/FlashMintExecutor.t.sol
  • Add integration tests for index base deployments

@ckoopmann
Copy link
Contributor

Happy to take over from here.

@ckoopmann
Copy link
Contributor

ckoopmann commented Feb 16, 2025

Note:
In the uniswap x docs I could only find mainnet deployment addresses.
I will do the integration tests on mainnet for now. Should be trivial to extend them to the base leverage tokens afterwards.

Note that i could find arbitrum deployment addresses for the dutch order reactors here

@ckoopmann ckoopmann marked this pull request as ready for review February 20, 2025 09:18
Copy link
Contributor Author

@pblivin0x pblivin0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, are we able to add a linter to CI

@ckoopmann
Copy link
Contributor

LGTM, are we able to add a linter to CI

Added a 'forge fmt' step to the ci, to check the formatting of all solidity code in the repo.
We can review at a later point if we want to get more extensive linting beyond mere formatting changes.

@ckoopmann ckoopmann merged commit 8eb37c6 into main Feb 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants