Refactor Image node and tools to avoid saving image fallback on the state by jesusmpc · Pull Request #1094 · InditexTech/weavejs

jesusmpc · 2026-06-03T11:04:46Z

Closes #1089

github-actions · 2026-06-03T11:05:34Z

❗ ❗ ❗ This Pull Request will not trigger a Release

A Pull Request with no changes to the code/ folder will not trigger a release

…ta on the room state

github-actions · 2026-06-03T11:08:09Z

❗ ❗ ❗ This Pull Request will not trigger a Release

A Pull Request with no changes to the code/ folder will not trigger a release

github-actions · 2026-06-03T11:09:11Z

🚀 Release Preview Success

You are going to release the version major with the following changes:

5.0.0 - 2026-06-03

Added

#1080 [alpha] API to manipulate document state natively on server-side

Changed

#1089 Refactor Image node and tools to avoid saving image fallback on the state
#1090 Remove usage of @syncedstore/core
#1091 Make Store Connection Lifecycle Asynchronous and Increase Azure Web PubSub Frame Size to 512 KB

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (improvement/GH-1089-refactor-image-node-and → main).

github-actions · 2026-06-03T11:41:34Z

🚀 Release Preview Success

You are going to release the version major with the following changes:

5.0.0 - 2026-06-03

Added

#1080 [alpha] API to manipulate document state natively on server-side

Changed

#1089 Refactor Image node and tools to avoid saving image fallback on the state
#1090 Remove usage of @syncedstore/core
#1091 Make Store Connection Lifecycle Asynchronous and Increase Azure Web PubSub Frame Size to 512 KB

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (improvement/GH-1089-refactor-image-node-and → main).

github-actions · 2026-06-03T12:44:56Z

🚀 Release Preview Success

You are going to release the version major with the following changes:

5.0.0 - 2026-06-03

Added

#1080 [alpha] API to manipulate document state natively on server-side

Changed

#1089 Refactor Image node and tools to avoid saving image fallback on the state
#1090 Remove usage of @syncedstore/core
#1091 Make Store Connection Lifecycle Asynchronous and Increase Azure Web PubSub Frame Size to 512 KB

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (improvement/GH-1089-refactor-image-node-and → main).

jesusmpc · 2026-06-03T12:44:57Z

/publish-snapshot

github-actions · 2026-06-03T12:46:57Z

🚀 NPM snapshot published

Version: 5.0.0-SNAPSHOT.336.1
Tag: next
Auth: OIDC trusted publishing (provenance)

jesusmpc · 2026-06-03T14:21:29Z

/publish-snapshot

github-actions · 2026-06-03T14:21:42Z

🚀 Release Preview Success

You are going to release the version major with the following changes:

5.0.0 - 2026-06-03

Added

#1080 [alpha] API to manipulate document state natively on server-side

Changed

#1089 Refactor Image node and tools to avoid saving image fallback on the state
#1090 Remove usage of @syncedstore/core
#1091 Make Store Connection Lifecycle Asynchronous and Increase Azure Web PubSub Frame Size to 512 KB

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (improvement/GH-1089-refactor-image-node-and → main).

github-actions · 2026-06-03T14:23:29Z

🚀 NPM snapshot published

Version: 5.0.0-SNAPSHOT.338.1
Tag: next
Auth: OIDC trusted publishing (provenance)

github-actions · 2026-06-03T14:27:49Z

🚀 Release Preview Success

You are going to release the version major with the following changes:

5.0.0 - 2026-06-03

Added

#1080 [alpha] API to manipulate document state natively on server-side

Changed

#1089 Refactor Image node and tools to avoid saving image fallback on the state
#1090 Remove usage of @syncedstore/core
#1091 Make Store Connection Lifecycle Asynchronous and Increase Azure Web PubSub Frame Size to 512 KB

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (improvement/GH-1089-refactor-image-node-and → main).

github-actions · 2026-06-03T14:44:19Z

🚀 Release Preview Success

You are going to release the version major with the following changes:

5.0.0 - 2026-06-03

Added

#1080 [alpha] API to manipulate document state natively on server-side

Changed

#1089 Refactor Image node and tools to avoid saving image fallback on the state
#1090 Remove usage of @syncedstore/core
#1091 Make Store Connection Lifecycle Asynchronous and Increase Azure Web PubSub Frame Size to 512 KB

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (improvement/GH-1089-refactor-image-node-and → main).

github-actions · 2026-06-03T14:53:28Z

🚀 Release Preview Success

You are going to release the version major with the following changes:

5.0.0 - 2026-06-03

Added

#1080 [alpha] API to manipulate document state natively on server-side

Changed

#1089 Refactor Image node and tools to avoid saving image fallback on the state
#1090 Remove usage of @syncedstore/core
#1091 Make Store Connection Lifecycle Asynchronous and Increase Azure Web PubSub Frame Size to 512 KB

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (improvement/GH-1089-refactor-image-node-and → main).

jesusmpc · 2026-06-03T14:53:35Z

/publish-snapshot

github-actions · 2026-06-03T14:55:32Z

🚀 NPM snapshot published

Version: 5.0.0-SNAPSHOT.342.1
Tag: next
Auth: OIDC trusted publishing (provenance)

github-actions · 2026-06-03T15:12:04Z

🚀 Release Preview Success

You are going to release the version major with the following changes:

5.0.0 - 2026-06-03

Added

#1080 [alpha] API to manipulate document state natively on server-side

Changed

#1089 Refactor Image node and tools to avoid saving image fallback on the state
#1090 Remove usage of @syncedstore/core
#1091 Make Store Connection Lifecycle Asynchronous and Increase Azure Web PubSub Frame Size to 512 KB

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (improvement/GH-1089-refactor-image-node-and → main).

github-actions · 2026-06-16T09:02:07Z

🚀 Release Preview Success

You are going to release the version major with the following changes:

5.0.0 - 2026-06-16

Added

#1080 [alpha] API to manipulate document state natively on server-side

Changed

#1089 Refactor Image node and tools to avoid saving image fallback on the state
#1090 Remove usage of @syncedstore/core
#1091 Make Store Connection Lifecycle Asynchronous and Increase Azure Web PubSub Frame Size to 512 KB

Fixed

#1088 Is not possible to draw a dot or very small line in the canvas using the brush tool
#1098 WeaveTextNode: textarea edit overlay misaligns due to hardcoded border offset and scrollHeight approximation

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (improvement/GH-1089-refactor-image-node-and → main).

github-actions · 2026-06-16T11:24:59Z

🚀 Release Preview Success

You are going to release the version major with the following changes:

5.0.0 - 2026-06-16

Added

#1080 [alpha] API to manipulate document state natively on server-side
#1101 Add inline text labels to shape nodes (Rectangle and Ellipse)
#1104 Add Polygon Node and Polygon Drawing Tool with Label Support

Changed

#1089 Refactor Image node and tools to avoid saving image fallback on the state
#1090 Remove usage of @syncedstore/core
#1091 Make Store Connection Lifecycle Asynchronous and Increase Azure Web PubSub Frame Size to 512 KB

Fixed

#1088 Is not possible to draw a dot or very small line in the canvas using the brush tool
#1098 WeaveTextNode: textarea edit overlay misaligns due to hardcoded border offset and scrollHeight approximation

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (improvement/GH-1089-refactor-image-node-and → main).

jesusmpc · 2026-06-16T11:28:27Z

/publish-snapshot

github-actions · 2026-06-16T11:31:37Z

🚀 NPM snapshot published

Version: 5.0.0-SNAPSHOT.397.1
Tag: next
Auth: OIDC trusted publishing (provenance)

github-actions · 2026-06-17T07:46:44Z

🚀 Release Preview Success

You are going to release the version major with the following changes:

5.0.0 - 2026-06-17

Added

#1039 Allow editing individual elements inside a group without ungrouping
#1080 [alpha] API to manipulate document state natively on server-side
#1101 Add inline text labels to shape nodes (Rectangle and Ellipse)
#1104 Add Polygon Node and Polygon Drawing Tool with Label Support

Changed

#1089 Refactor Image node and tools to avoid saving image fallback on the state
#1090 Remove usage of @syncedstore/core
#1091 Make Store Connection Lifecycle Asynchronous and Increase Azure Web PubSub Frame Size to 512 KB

Fixed

#1088 Is not possible to draw a dot or very small line in the canvas using the brush tool
#1098 WeaveTextNode: textarea edit overlay misaligns due to hardcoded border offset and scrollHeight approximation

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (improvement/GH-1089-refactor-image-node-and → main).

jesusmpc · 2026-06-17T07:48:00Z

/publish-snapshot

github-actions · 2026-06-17T07:51:29Z

🚀 NPM snapshot published

Version: 5.0.0-SNAPSHOT.403.1
Tag: next
Auth: OIDC trusted publishing (provenance)

jesusmpc · 2026-06-17T15:18:49Z

/publish-snapshot

github-actions · 2026-06-17T15:19:18Z

🚀 Release Preview Success

You are going to release the version major with the following changes:

5.0.0 - 2026-06-17

Added

#1039 Allow editing individual elements inside a group without ungrouping
#1080 [alpha] API to manipulate document state natively on server-side
#1101 Add inline text labels to shape nodes (Rectangle and Ellipse)
#1104 Add Polygon Node and Polygon Drawing Tool with Label Support
#1106 Add y-indexeddb client-side persistence to WeaveStoreAzureWebPubsub for optimistic initial render

Changed

#1089 Refactor Image node and tools to avoid saving image fallback on the state
#1090 Remove usage of @syncedstore/core
#1091 Make Store Connection Lifecycle Asynchronous and Increase Azure Web PubSub Frame Size to 512 KB

Fixed

#1088 Is not possible to draw a dot or very small line in the canvas using the brush tool
#1098 WeaveTextNode: textarea edit overlay misaligns due to hardcoded border offset and scrollHeight approximation

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (improvement/GH-1089-refactor-image-node-and → main).

github-actions · 2026-06-17T15:22:04Z

🚀 NPM snapshot published

Version: 5.0.0-SNAPSHOT.409.1
Tag: next
Auth: OIDC trusted publishing (provenance)

… image, images, video tools

github-actions · 2026-06-18T07:32:07Z

🚀 Release Preview Success

You are going to release the version major with the following changes:

5.0.0 - 2026-06-18

Added

#1039 Allow editing individual elements inside a group without ungrouping
#1080 [alpha] API to manipulate document state natively on server-side
#1101 Add inline text labels to shape nodes (Rectangle and Ellipse)
#1104 Add Polygon Node and Polygon Drawing Tool with Label Support
#1106 Add y-indexeddb client-side persistence to WeaveStoreAzureWebPubsub for optimistic initial render

Changed

#1089 Refactor Image node and tools to avoid saving image fallback on the state
#1090 Remove usage of @syncedstore/core
#1091 Make Store Connection Lifecycle Asynchronous and Increase Azure Web PubSub Frame Size to 512 KB

Fixed

#1088 Is not possible to draw a dot or very small line in the canvas using the brush tool
#1098 WeaveTextNode: textarea edit overlay misaligns due to hardcoded border offset and scrollHeight approximation

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (improvement/GH-1089-refactor-image-node-and → main).

jesusmpc · 2026-06-18T07:32:21Z

/publish-snapshot

github-actions · 2026-06-18T07:33:55Z

❌ NPM snapshot publication failed

Please check the workflow logs for details.

jesusmpc · 2026-06-18T07:41:12Z

/publish-snapshot

github-actions · 2026-06-18T07:41:28Z

🚀 Release Preview Success

You are going to release the version major with the following changes:

5.0.0 - 2026-06-18

Added

#1039 Allow editing individual elements inside a group without ungrouping
#1080 [alpha] API to manipulate document state natively on server-side
#1101 Add inline text labels to shape nodes (Rectangle and Ellipse)
#1104 Add Polygon Node and Polygon Drawing Tool with Label Support
#1106 Add y-indexeddb client-side persistence to WeaveStoreAzureWebPubsub for optimistic initial render

Changed

#1089 Refactor Image node and tools to avoid saving image fallback on the state
#1090 Remove usage of @syncedstore/core
#1091 Make Store Connection Lifecycle Asynchronous and Increase Azure Web PubSub Frame Size to 512 KB

Fixed

#1088 Is not possible to draw a dot or very small line in the canvas using the brush tool
#1098 WeaveTextNode: textarea edit overlay misaligns due to hardcoded border offset and scrollHeight approximation

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (improvement/GH-1089-refactor-image-node-and → main).

github-actions · 2026-06-18T07:43:56Z

🚀 NPM snapshot published

Version: 5.0.0-SNAPSHOT.413.1
Tag: next
Auth: OIDC trusted publishing (provenance)

github-actions · 2026-06-18T08:00:09Z

🚀 Release Preview Success

You are going to release the version major with the following changes:

5.0.0 - 2026-06-18

Added

#1039 Allow editing individual elements inside a group without ungrouping
#1080 [alpha] API to manipulate document state natively on server-side
#1101 Add inline text labels to shape nodes (Rectangle and Ellipse)
#1104 Add Polygon Node and Polygon Drawing Tool with Label Support
#1106 Add y-indexeddb client-side persistence to WeaveStoreAzureWebPubsub for optimistic initial render

Changed

#1089 Refactor Image node and tools to avoid saving image fallback on the state
#1090 Remove usage of @syncedstore/core
#1091 Make Store Connection Lifecycle Asynchronous and Increase Azure Web PubSub Frame Size to 512 KB

Fixed

#1088 Is not possible to draw a dot or very small line in the canvas using the brush tool
#1098 WeaveTextNode: textarea edit overlay misaligns due to hardcoded border offset and scrollHeight approximation

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (improvement/GH-1089-refactor-image-node-and → main).

Add targeted unit tests for WeaveImageNode and WeaveNodesSnappingCustomGuides to lift new-code coverage above the 80% SonarQube quality-gate threshold. nodes-snapping.custom-guides.test.ts: - deserialize() falsy/error branches - initialize() with persistence.enabled=true (hook, metadata listener, window pointermove/keyup/keydown handlers) - editCustomGuide/deleteCustomGuide with persist=true - stagePanChangeHandler / zoomChangeHandler - renderGuide() VERTICAL/HORIZONTAL, container-relative, static kind - toggleCustomGuides on/off event wiring - pointerClickHandler, arrowKeysHandler, deleteGuide branches - createGuideNode event handlers via captured-handler pattern image.test.ts: - getImageFallbackId / saveImageFallback / cacheImageFallbackURL (imageFallback.enabled=true paths) - isImageFallbackEnabled / getFallbackImageSource / getFallbackImageSourceURL / getImageSource getter helpers - forceLoadFallbackImage (node found / not found) - group.triggerCrop() / group.closeCrop() / group.resetCrop() callbacks assigned during onRender - nodeDragStart / onCmdCtrlPressed / onCmdCtrlReleased early-return branches (utilityLayer null, isDragging, transformer null) - onUpdate cropInfo / cropSize truthy branches and empty-imageURL path - triggerCrop missing-image early return and show-callback body - cropImageWithReference with nodeHandler (removeNodeNT path) - updateNodeState with/without imageId Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-06-18T08:37:45Z

🚀 Release Preview Success

You are going to release the version major with the following changes:

5.0.0 - 2026-06-18

Added

#1039 Allow editing individual elements inside a group without ungrouping
#1080 [alpha] API to manipulate document state natively on server-side
#1101 Add inline text labels to shape nodes (Rectangle and Ellipse)
#1104 Add Polygon Node and Polygon Drawing Tool with Label Support
#1106 Add y-indexeddb client-side persistence to WeaveStoreAzureWebPubsub for optimistic initial render

Changed

#1089 Refactor Image node and tools to avoid saving image fallback on the state
#1090 Remove usage of @syncedstore/core
#1091 Make Store Connection Lifecycle Asynchronous and Increase Azure Web PubSub Frame Size to 512 KB

Fixed

#1088 Is not possible to draw a dot or very small line in the canvas using the brush tool
#1098 WeaveTextNode: textarea edit overlay misaligns due to hardcoded border offset and scrollHeight approximation

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (improvement/GH-1089-refactor-image-node-and → main).

…es updates on doc

github-actions · 2026-06-18T10:11:00Z

🚀 Release Preview Success

You are going to release the version major with the following changes:

5.0.0 - 2026-06-18

Added

#1039 Allow editing individual elements inside a group without ungrouping
#1080 [alpha] API to manipulate document state natively on server-side
#1101 Add inline text labels to shape nodes (Rectangle and Ellipse)
#1104 Add Polygon Node and Polygon Drawing Tool with Label Support
#1106 Add y-indexeddb client-side persistence to WeaveStoreAzureWebPubsub for optimistic initial render

Changed

#1089 Refactor Image node and tools to avoid saving image fallback on the state
#1090 Remove usage of @syncedstore/core
#1091 Make Store Connection Lifecycle Asynchronous and Increase Azure Web PubSub Frame Size to 512 KB

Fixed

#1088 Is not possible to draw a dot or very small line in the canvas using the brush tool
#1098 WeaveTextNode: textarea edit overlay misaligns due to hardcoded border offset and scrollHeight approximation

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (improvement/GH-1089-refactor-image-node-and → main).

sonarqubecloud · 2026-06-18T10:14:21Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.4% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarQube Cloud

chore: initial commit

3ff9d44

jesusmpc self-assigned this Jun 3, 2026

jesusmpc added the release-type/major label Jun 3, 2026

feat: refactor image node and tools to avoid saving image fallback da…

99d43ac

…ta on the room state

jesusmpc marked this pull request as ready for review June 3, 2026 11:07

chore: fix code smells

3858cf7

chore: fix code smell

15a9281

chore: improvement on exporting API

556adec

chore: fix code duplications

6a9372b

chore: refactor missing export area methods

a64e98a

chore: refactor missing export area methods

19623db

jesusmpc added 2 commits June 3, 2026 17:03

chore: updated docs

88ba20e

chore: updated docs

dcdc542

chore: guides fixes

5bf3b8e

Merge branch 'main' into improvement/GH-1089-refactor-image-node-and

c5ee316

Merge branch 'main' into improvement/GH-1089-refactor-image-node-and

a3c07a6

Merge branch 'main' into improvement/GH-1089-refactor-image-node-and

7afab78

feat: new font loading api - improved perf and complexity -, fixes on…

b407d5b

… image, images, video tools

chore: fix PR issues

20c6af4

chore: fix sonarqube issues

8f56c16

fix: issue with node updates when updated inside a group, release nod…

e043293

…es updates on doc

jesusmpc merged commit c2949a6 into main Jun 18, 2026
16 checks passed

jesusmpc deleted the improvement/GH-1089-refactor-image-node-and branch June 18, 2026 10:16

Conversation

jesusmpc commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 3, 2026

❗ ❗ ❗ This Pull Request will not trigger a Release

Uh oh!

github-actions Bot commented Jun 3, 2026

❗ ❗ ❗ This Pull Request will not trigger a Release

Uh oh!

github-actions Bot commented Jun 3, 2026

🚀 Release Preview Success

5.0.0 - 2026-06-03

Added

Changed

💡 Merge Strategy: Squash and Merge

Uh oh!

github-actions Bot commented Jun 3, 2026

🚀 Release Preview Success

5.0.0 - 2026-06-03

Added

Changed

💡 Merge Strategy: Squash and Merge

Uh oh!

github-actions Bot commented Jun 3, 2026

🚀 Release Preview Success

5.0.0 - 2026-06-03

Added

Changed

💡 Merge Strategy: Squash and Merge

Uh oh!

jesusmpc commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 3, 2026

🚀 NPM snapshot published

Uh oh!

jesusmpc commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 3, 2026

🚀 Release Preview Success

5.0.0 - 2026-06-03

Added

Changed

💡 Merge Strategy: Squash and Merge

Uh oh!

github-actions Bot commented Jun 3, 2026

🚀 NPM snapshot published

Uh oh!

github-actions Bot commented Jun 3, 2026

🚀 Release Preview Success

5.0.0 - 2026-06-03

Added

Changed

💡 Merge Strategy: Squash and Merge

Uh oh!

github-actions Bot commented Jun 3, 2026

🚀 Release Preview Success

5.0.0 - 2026-06-03

Added

Changed

💡 Merge Strategy: Squash and Merge

Uh oh!

github-actions Bot commented Jun 3, 2026

🚀 Release Preview Success

5.0.0 - 2026-06-03

Added

Changed

💡 Merge Strategy: Squash and Merge

Uh oh!

jesusmpc commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 3, 2026

🚀 NPM snapshot published

Uh oh!

github-actions Bot commented Jun 3, 2026

🚀 Release Preview Success

5.0.0 - 2026-06-03

Added

Changed

💡 Merge Strategy: Squash and Merge

Uh oh!