Skip to content

Fix Video node TS types issues and rotation #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jesusmpc merged 2 commits into from
Oct 9, 2025
Merged

Fix Video node TS types issues and rotation #704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc63ef1
chore: initial commit
jesusmpc Oct 9, 2025
49894ef
fix: video node typings issue and rotation fix
jesusmpc Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
145 changes: 4 additions & 141 deletions code/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- [#701](https://github.com/InditexTech/weavejs/issues/701) Fix Video node TS types issues and rotation

## [0.74.0] - 2025-10-09

### Added
Expand Down Expand Up @@ -1110,285 +1114,144 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [#18](https://github.com/InditexTech/weavejs/issues/18) Fix awareness not working on store-azure-web-pubsub

[Unreleased]: https://github.com/InditexTech/weavejs/compare/0.74.0...HEAD

[0.74.0]: https://github.com/InditexTech/weavejs/compare/0.73.1...0.74.0

[0.73.1]: https://github.com/InditexTech/weavejs/compare/0.73.0...0.73.1

[0.73.0]: https://github.com/InditexTech/weavejs/compare/0.72.1...0.73.0

[0.72.1]: https://github.com/InditexTech/weavejs/compare/0.72.0...0.72.1

[0.72.0]: https://github.com/InditexTech/weavejs/compare/0.71.0...0.72.0

[0.71.0]: https://github.com/InditexTech/weavejs/compare/0.70.0...0.71.0

[0.70.0]: https://github.com/InditexTech/weavejs/compare/0.69.2...0.70.0

[0.69.2]: https://github.com/InditexTech/weavejs/compare/0.69.1...0.69.2

[0.69.1]: https://github.com/InditexTech/weavejs/compare/0.69.0...0.69.1

[0.69.0]: https://github.com/InditexTech/weavejs/compare/0.68.1...0.69.0

[0.68.1]: https://github.com/InditexTech/weavejs/compare/0.68.0...0.68.1

[0.68.0]: https://github.com/InditexTech/weavejs/compare/0.67.5...0.68.0

[0.67.5]: https://github.com/InditexTech/weavejs/compare/0.67.4...0.67.5

[0.67.4]: https://github.com/InditexTech/weavejs/compare/0.67.3...0.67.4

[0.67.3]: https://github.com/InditexTech/weavejs/compare/0.67.2...0.67.3

[0.67.2]: https://github.com/InditexTech/weavejs/compare/0.67.1...0.67.2

[0.67.1]: https://github.com/InditexTech/weavejs/compare/0.67.0...0.67.1

[0.67.0]: https://github.com/InditexTech/weavejs/compare/0.66.0...0.67.0

[0.66.0]: https://github.com/InditexTech/weavejs/compare/0.64.0...0.66.0

[0.64.0]: https://github.com/InditexTech/weavejs/compare/0.62.4...0.64.0

[0.62.4]: https://github.com/InditexTech/weavejs/compare/0.62.3...0.62.4

[0.62.3]: https://github.com/InditexTech/weavejs/compare/0.62.2...0.62.3

[0.62.2]: https://github.com/InditexTech/weavejs/compare/0.62.1...0.62.2

[0.62.1]: https://github.com/InditexTech/weavejs/compare/0.62.0...0.62.1

[0.62.0]: https://github.com/InditexTech/weavejs/compare/0.61.0...0.62.0

[0.61.0]: https://github.com/InditexTech/weavejs/compare/0.60.0...0.61.0

[0.60.0]: https://github.com/InditexTech/weavejs/compare/0.59.0...0.60.0

[0.59.0]: https://github.com/InditexTech/weavejs/compare/0.58.0...0.59.0

[0.58.0]: https://github.com/InditexTech/weavejs/compare/0.57.1...0.58.0

[0.57.1]: https://github.com/InditexTech/weavejs/compare/0.57.0...0.57.1

[0.57.0]: https://github.com/InditexTech/weavejs/compare/0.56.2...0.57.0

[0.56.2]: https://github.com/InditexTech/weavejs/compare/0.56.1...0.56.2

[0.56.1]: https://github.com/InditexTech/weavejs/compare/0.56.0...0.56.1

[0.56.0]: https://github.com/InditexTech/weavejs/compare/0.55.2...0.56.0

[0.55.2]: https://github.com/InditexTech/weavejs/compare/0.55.1...0.55.2

[0.55.1]: https://github.com/InditexTech/weavejs/compare/0.55.0...0.55.1

[0.55.0]: https://github.com/InditexTech/weavejs/compare/0.54.1...0.55.0

[0.54.1]: https://github.com/InditexTech/weavejs/compare/0.54.0...0.54.1

[0.54.0]: https://github.com/InditexTech/weavejs/compare/0.53.0...0.54.0

[0.53.0]: https://github.com/InditexTech/weavejs/compare/0.52.3...0.53.0

[0.52.3]: https://github.com/InditexTech/weavejs/compare/0.52.2...0.52.3

[0.52.2]: https://github.com/InditexTech/weavejs/compare/0.52.1...0.52.2

[0.52.1]: https://github.com/InditexTech/weavejs/compare/0.52.0...0.52.1

[0.52.0]: https://github.com/InditexTech/weavejs/compare/0.51.0...0.52.0

[0.51.0]: https://github.com/InditexTech/weavejs/compare/0.50.0...0.51.0

[0.50.0]: https://github.com/InditexTech/weavejs/compare/0.49.0...0.50.0

[0.49.0]: https://github.com/InditexTech/weavejs/compare/0.48.0...0.49.0

[0.48.0]: https://github.com/InditexTech/weavejs/compare/0.47.1...0.48.0

[0.47.1]: https://github.com/InditexTech/weavejs/compare/0.47.0...0.47.1

[0.47.0]: https://github.com/InditexTech/weavejs/compare/0.46.1...0.47.0

[0.46.1]: https://github.com/InditexTech/weavejs/compare/0.46.0...0.46.1

[0.46.0]: https://github.com/InditexTech/weavejs/compare/0.45.0...0.46.0

[0.45.0]: https://github.com/InditexTech/weavejs/compare/0.44.0...0.45.0

[0.44.0]: https://github.com/InditexTech/weavejs/compare/0.43.0...0.44.0

[0.43.0]: https://github.com/InditexTech/weavejs/compare/0.42.2...0.43.0

[0.42.2]: https://github.com/InditexTech/weavejs/compare/0.42.1...0.42.2

[0.42.1]: https://github.com/InditexTech/weavejs/compare/0.42.0...0.42.1

[0.42.0]: https://github.com/InditexTech/weavejs/compare/0.41.0...0.42.0

[0.41.0]: https://github.com/InditexTech/weavejs/compare/0.40.2...0.41.0

[0.40.2]: https://github.com/InditexTech/weavejs/compare/0.40.1...0.40.2

[0.40.1]: https://github.com/InditexTech/weavejs/compare/0.40.0...0.40.1

[0.40.0]: https://github.com/InditexTech/weavejs/compare/0.39.3...0.40.0

[0.39.3]: https://github.com/InditexTech/weavejs/compare/0.39.2...0.39.3

[0.39.2]: https://github.com/InditexTech/weavejs/compare/0.39.1...0.39.2

[0.39.1]: https://github.com/InditexTech/weavejs/compare/0.39.0...0.39.1

[0.39.0]: https://github.com/InditexTech/weavejs/compare/0.38.0...0.39.0

[0.38.0]: https://github.com/InditexTech/weavejs/compare/0.37.0...0.38.0

[0.37.0]: https://github.com/InditexTech/weavejs/compare/0.36.0...0.37.0

[0.36.0]: https://github.com/InditexTech/weavejs/compare/0.35.0...0.36.0

[0.35.0]: https://github.com/InditexTech/weavejs/compare/0.34.0...0.35.0

[0.34.0]: https://github.com/InditexTech/weavejs/compare/0.33.0...0.34.0

[0.33.0]: https://github.com/InditexTech/weavejs/compare/0.32.0...0.33.0

[0.32.0]: https://github.com/InditexTech/weavejs/compare/0.31.1...0.32.0

[0.31.1]: https://github.com/InditexTech/weavejs/compare/0.31.0...0.31.1

[0.31.0]: https://github.com/InditexTech/weavejs/compare/0.30.1...0.31.0

[0.30.1]: https://github.com/InditexTech/weavejs/compare/0.30.0...0.30.1

[0.30.0]: https://github.com/InditexTech/weavejs/compare/0.29.1...0.30.0

[0.29.1]: https://github.com/InditexTech/weavejs/compare/0.29.0...0.29.1

[0.29.0]: https://github.com/InditexTech/weavejs/compare/0.28.0...0.29.0

[0.28.0]: https://github.com/InditexTech/weavejs/compare/0.27.4...0.28.0

[0.27.4]: https://github.com/InditexTech/weavejs/compare/0.27.3...0.27.4

[0.27.3]: https://github.com/InditexTech/weavejs/compare/0.27.2...0.27.3

[0.27.2]: https://github.com/InditexTech/weavejs/compare/0.27.1...0.27.2

[0.27.1]: https://github.com/InditexTech/weavejs/compare/0.27.0...0.27.1

[0.27.0]: https://github.com/InditexTech/weavejs/compare/0.26.2...0.27.0

[0.26.2]: https://github.com/InditexTech/weavejs/compare/0.26.1...0.26.2

[0.26.1]: https://github.com/InditexTech/weavejs/compare/0.26.0...0.26.1

[0.26.0]: https://github.com/InditexTech/weavejs/compare/0.25.0...0.26.0

[0.25.0]: https://github.com/InditexTech/weavejs/compare/0.24.1...0.25.0

[0.24.1]: https://github.com/InditexTech/weavejs/compare/0.24.0...0.24.1

[0.24.0]: https://github.com/InditexTech/weavejs/compare/0.23.1...0.24.0

[0.23.1]: https://github.com/InditexTech/weavejs/compare/0.23.0...0.23.1

[0.23.0]: https://github.com/InditexTech/weavejs/compare/0.22.1...0.23.0

[0.22.1]: https://github.com/InditexTech/weavejs/compare/0.22.0...0.22.1

[0.22.0]: https://github.com/InditexTech/weavejs/compare/0.21.2...0.22.0

[0.21.2]: https://github.com/InditexTech/weavejs/compare/0.21.1...0.21.2

[0.21.1]: https://github.com/InditexTech/weavejs/compare/0.21.0...0.21.1

[0.21.0]: https://github.com/InditexTech/weavejs/compare/0.20.4...0.21.0

[0.20.4]: https://github.com/InditexTech/weavejs/compare/0.20.3...0.20.4

[0.20.3]: https://github.com/InditexTech/weavejs/compare/0.20.2...0.20.3

[0.20.2]: https://github.com/InditexTech/weavejs/compare/0.20.1...0.20.2

[0.20.1]: https://github.com/InditexTech/weavejs/compare/0.20.0...0.20.1

[0.20.0]: https://github.com/InditexTech/weavejs/compare/0.19.0...0.20.0

[0.19.0]: https://github.com/InditexTech/weavejs/compare/0.18.0...0.19.0

[0.18.0]: https://github.com/InditexTech/weavejs/compare/0.17.0...0.18.0

[0.17.0]: https://github.com/InditexTech/weavejs/compare/0.16.2...0.17.0

[0.16.2]: https://github.com/InditexTech/weavejs/compare/0.16.1...0.16.2

[0.16.1]: https://github.com/InditexTech/weavejs/compare/0.16.0...0.16.1

[0.16.0]: https://github.com/InditexTech/weavejs/compare/0.15.0...0.16.0

[0.15.0]: https://github.com/InditexTech/weavejs/compare/0.14.3...0.15.0

[0.14.3]: https://github.com/InditexTech/weavejs/compare/0.14.2...0.14.3

[0.14.2]: https://github.com/InditexTech/weavejs/compare/0.14.1...0.14.2

[0.14.1]: https://github.com/InditexTech/weavejs/compare/0.14.0...0.14.1

[0.14.0]: https://github.com/InditexTech/weavejs/compare/0.13.1...0.14.0

[0.13.1]: https://github.com/InditexTech/weavejs/compare/0.13.0...0.13.1

[0.13.0]: https://github.com/InditexTech/weavejs/compare/0.12.1...0.13.0

[0.12.1]: https://github.com/InditexTech/weavejs/compare/0.12.0...0.12.1

[0.12.0]: https://github.com/InditexTech/weavejs/compare/0.11.0...0.12.0

[0.11.0]: https://github.com/InditexTech/weavejs/compare/0.10.3...0.11.0

[0.10.3]: https://github.com/InditexTech/weavejs/compare/0.10.2...0.10.3

[0.10.2]: https://github.com/InditexTech/weavejs/compare/0.10.1...0.10.2

[0.10.1]: https://github.com/InditexTech/weavejs/compare/0.10.0...0.10.1

[0.10.0]: https://github.com/InditexTech/weavejs/compare/0.9.3...0.10.0

[0.9.3]: https://github.com/InditexTech/weavejs/compare/0.9.2...0.9.3

[0.9.2]: https://github.com/InditexTech/weavejs/compare/0.9.1...0.9.2

[0.9.1]: https://github.com/InditexTech/weavejs/compare/0.9.0...0.9.1

[0.9.0]: https://github.com/InditexTech/weavejs/compare/0.8.0...0.9.0

[0.8.0]: https://github.com/InditexTech/weavejs/compare/0.7.1...0.8.0

[0.7.1]: https://github.com/InditexTech/weavejs/compare/0.7.0...0.7.1

[0.7.0]: https://github.com/InditexTech/weavejs/compare/0.6.0...0.7.0

[0.6.0]: https://github.com/InditexTech/weavejs/compare/0.5.0...0.6.0

[0.5.0]: https://github.com/InditexTech/weavejs/compare/0.4.0...0.5.0

[0.4.0]: https://github.com/InditexTech/weavejs/compare/0.3.3...0.4.0

[0.3.3]: https://github.com/InditexTech/weavejs/compare/0.3.2...0.3.3

[0.3.2]: https://github.com/InditexTech/weavejs/compare/0.3.1...0.3.2

[0.3.1]: https://github.com/InditexTech/weavejs/compare/0.3.0...0.3.1

[0.3.0]: https://github.com/InditexTech/weavejs/compare/0.2.1...0.3.0

[0.2.1]: https://github.com/InditexTech/weavejs/compare/0.2.0...0.2.1

[0.2.0]: https://github.com/InditexTech/weavejs/compare/0.1.1...0.2.0

[0.1.1]: https://github.com/InditexTech/weavejs/compare/0.1.0...0.1.1

[0.1.0]: https://github.com/InditexTech/weavejs/releases/tag/0.1.0
3 changes: 2 additions & 1 deletion code/packages/sdk/src/nodes/video/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// SPDX-License-Identifier: Apache-2.0

import {
type DeepPartial,
type ImageCrossOrigin,
type URLTransformerFunction,
type WeaveElementAttributes,
Expand Down Expand Up @@ -78,7 +79,7 @@ export type WeaveVideoProperties = {
};

export type WeaveVideoNodeParams = {
config: Partial<WeaveVideoProperties>;
config: DeepPartial<WeaveVideoProperties>;
};

export type WeaveVideoOnVideoPlayEvent = {
Expand Down
9 changes: 9 additions & 0 deletions code/packages/sdk/src/nodes/video/video.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ export class WeaveVideoNode extends WeaveNode {
stroke: this.config.style.background.strokeColor,
strokeWidth: this.config.style.background.strokeWidth,
nodeId: id,
rotation: 0,
});

videoGroup.add(bg);
Expand All @@ -308,6 +309,7 @@ export class WeaveVideoNode extends WeaveNode {
image: undefined,
name: undefined,
nodeId: id,
rotation: 0,
});

video.hide();
Expand All @@ -325,6 +327,7 @@ export class WeaveVideoNode extends WeaveNode {
fill: this.config.style.track.color,
name: undefined,
nodeId: id,
rotation: 0,
});

this.instance.addEventListener<WeaveStageZoomPluginOnZoomChangeEvent>(
Expand Down Expand Up @@ -352,6 +355,7 @@ export class WeaveVideoNode extends WeaveNode {
image: undefined,
name: undefined,
nodeId: id,
rotation: 0,
});

videoPlaceholder.show();
Expand All @@ -378,6 +382,7 @@ export class WeaveVideoNode extends WeaveNode {
stroke: this.config.style.iconBackground.strokeColor,
fill: this.config.style.iconBackground.color,
nodeId: id,
rotation: 0,
});

videoIconGroup.add(videoIconBg);
Expand All @@ -392,6 +397,7 @@ export class WeaveVideoNode extends WeaveNode {
fill: 'transparent',
image: this.videoIconImage,
nodeId: id,
rotation: 0,
});

videoIconGroup.add(videoIcon);
Expand Down Expand Up @@ -763,6 +769,7 @@ export class WeaveVideoNode extends WeaveNode {

bg.setAttrs({
...internalVideoProps,
rotation: 0,
id: `${id}-bg`,
x: 0,
y: 0,
Expand All @@ -773,6 +780,7 @@ export class WeaveVideoNode extends WeaveNode {
if (!isServer() && video) {
video.setAttrs({
...internalVideoProps,
rotation: 0,
id: `${id}-video`,
x: 0,
y: 0,
Expand All @@ -781,6 +789,7 @@ export class WeaveVideoNode extends WeaveNode {
videoPlaceholder.setAttrs({
...internalVideoProps,
id: `${id}-video-placeholder`,
rotation: 0,
x: 0,
y: 0,
});
Expand Down
1 change: 1 addition & 0 deletions docs/content/docs/main/changelog/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ description: Check out the latest changes to Weave.js.

## Pre-release versions

- [**0.74.1**](/docs/main/changelog/prerelease/0.74.1)
- [**0.74.0**](/docs/main/changelog/prerelease/0.74.0)
- [**0.73.1**](/docs/main/changelog/prerelease/0.73.1)
- [**0.73.0**](/docs/main/changelog/prerelease/0.73.0)
Expand Down
Loading