chore: bump go versions #182
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/infisical/cli/e2e-tests | ||
|
|
||
| go 1.25.9 | ||
|
|
||
| require ( | ||
| github.com/Infisical/infisical-merge v0.0.0 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/Infisical/infisical-merge | ||
|
|
||
| go 1.25.9 | ||
|
|
||
| require ( | ||
| github.com/BobuSumisu/aho-corasick v1.0.3 | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟣 The three workflow files use inconsistent versions of
actions/setup-go:release_build_infisical_cli.ymluses@v3,run-cli-tests.ymluses@v4, andrun-cli-e2e-tests.ymluses@v6. This is a pre-existing inconsistency not introduced by this PR, but since all three files were touched to bump the Go version, it would have been a good opportunity to standardize on@v6everywhere.Extended reasoning...
What the bug is and how it manifests
The three CI workflow files use three different major versions of the
actions/setup-goaction:release_build_infisical_cli.ymluses@v3(in two separate job steps),run-cli-tests.ymluses@v4, andrun-cli-e2e-tests.ymluses@v6(in three separate job steps). Different major versions ofactions/setup-gohave different default behaviors around module caching, toolchain selection, and feature support. While all versions can install a specified Go version, the caching strategy and other behaviors differ.The specific code path that triggers it
In
release_build_infisical_cli.ymllines 102 and 184,actions/setup-go@v3is used. Inrun-cli-tests.ymlline 35,actions/setup-go@v4is used. Inrun-cli-e2e-tests.ymllines 16, 51, and 77,actions/setup-go@v6is used. The PR changed only thego-versionparameter (1.25.8 → 1.25.9) in all five locations without updating the action version references.Why existing code doesn't prevent it
This inconsistency pre-dates this PR and was already present in the repository. The PR author bumped the Go patch version across all three workflow files but did not take the opportunity to also standardize the
actions/setup-goversion. There are no automated checks in the repository to enforce consistent action versions across workflow files.What the impact would be
The practical impact is minor: all three action versions correctly install the specified Go version. However,
@v3and@v4have older caching mechanisms compared to@v6. The release build workflow uses@v3with explicitcache: trueandcache-dependency-pathparameters — in@v6these are enabled by default. Inconsistent behavior across CI environments can make debugging cache-related issues harder and may result in unnecessary cache misses or hits depending on the action version.How to fix it
Update all five
uses: actions/setup-go@vXreferences touses: actions/setup-go@v6for consistency. Since@v6enables caching by default, the explicitcache: trueandcache-dependency-path: go.sumparameters inrelease_build_infisical_cli.ymlcan be retained or left to defaults.Step-by-step proof
.github/workflows/release_build_infisical_cli.yml— line 102 showsuses: actions/setup-go@v3, and line 184 shows anotheruses: actions/setup-go@v3..github/workflows/run-cli-tests.yml— line 35 showsuses: actions/setup-go@v4..github/workflows/run-cli-e2e-tests.yml— lines 16, 51, and 77 each showuses: actions/setup-go@v6.go-versionchanges (1.25.8 → 1.25.9) at these lines, confirming the action version mismatch was pre-existing and unmodified by this PR.