feat: support fetching imported certificates in cert-agent#198
Conversation
|
💬 Discussion in Slack: #pr-review-cli-198-feat-support-fetching-imported-certificates-in-cert-agent Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73ebb0e57d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@claude review once |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
# Conflicts: # packages/cmd/agent.go
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 32113716 | Triggered | Generic Password | 8afc37d | dev/pam/resources/mssql/entrypoint.sh | View secret |
| 32113717 | Triggered | Generic Password | 8afc37d | dev/pam/resources/mongodb/init/seed.js | View secret |
| 32113718 | Triggered | Username Password | 8afc37d | dev/pam/setup.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
bernie-g
left a comment
bernie-g
left a comment
There was a problem hiding this comment.
Tested this and seems to work. Could be worth putting this in the docs as well.
2 participants
Description 📣
Adds support in the certificate agent for fetching an existing certificate by ID and writing the cert, chain, and private key in the desired destinations instead of always issuing a new certificate from a profile.
A new
imported-certificate-idconfig field selects this mode and skips the issuance flow entirely, periodic status checks still run so revocation and expiry are detected, but renewal is left to whatever issued the cert externally. When the imported certificate has no private key (e.g. ACME-issued), the agent logs a warning if aprivate-keypath is configured and otherwise stays quiet.Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets