Skip to content

feat(cli): add smoke tests across multiple distros#239

Open
x032205 wants to merge 3 commits into
mainfrom
ENG-5052
Open

feat(cli): add smoke tests across multiple distros#239
x032205 wants to merge 3 commits into
mainfrom
ENG-5052

Conversation

@x032205
Copy link
Copy Markdown
Member

@x032205 x032205 commented May 19, 2026

Description 📣

Add CLI smoke tests across multiple distros

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@linear
Copy link
Copy Markdown

linear Bot commented May 19, 2026

ENG-5052

@infisical-review-police
Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-cli-239-feat-cli-add-smoke-tests-across-multiple-distros

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

Comment thread .github/workflows/run-cli-smoke-tests.yml
Comment thread .github/workflows/run-cli-smoke-tests.yml Outdated
Comment thread smoke-tests/smoke.sh
@x032205
Copy link
Copy Markdown
Member Author

x032205 commented May 19, 2026

@claude review this PR once

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, comment @claude review on this pull request to trigger a review.

@x032205
Copy link
Copy Markdown
Member Author

x032205 commented May 20, 2026

@claude review this once

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — all prior comments are addressed (paths corrected, nfpm pinned to v2.46.3, ldd skip message clarified).

Extended reasoning...

Overview

This PR adds a CI workflow (run-cli-smoke-tests.yml) plus supporting files (smoke-tests/nfpm.yaml and smoke-tests/smoke.sh) that build the CLI as a static binary, package it via nfpm into deb/rpm/apk/archlinux formats, and run a shell-based smoke test (binary presence, --version, --help, core subcommand --help, static-binary check) across an 8-distro Docker matrix. No production code is touched.

Security risks

Minimal. The workflow triggers on pull_request, which means it doesn't get repo secrets, and it runs Docker on the GitHub-hosted ubuntu runner against pinned-version actions. The third-party tooling that gets fetched at run-time (nfpm) is now pinned to a specific tag (v2.46.3), eliminating the supply-chain concern from the prior revision. Container images in the matrix (e.g. alpine:3.20, fedora:40) are unpinned by tag, which is a minor reproducibility consideration but standard practice for smoke tests of this kind.

Level of scrutiny

Low. This is test-infrastructure code that does not ship to users, has no auth/crypto/permissions implications, and runs in an isolated CI context. The changes are mechanical and self-contained — well within the bar for shadow approval.

Other factors

The author explicitly requested a re-review after addressing my prior comments. Cross-checking the diff against those comments: the critical path mismatch (artifacts/smoke-tests/...artifacts/...) is fixed, nfpm@latest is now nfpm@v2.46.3, and the misleading PASS: no missing shared libraries line is replaced with an explicit static binary (no dynamic dependencies) branch. The bug hunting system found no new issues on this revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant