Skip to content

fix: add missing windows docker file#35

Merged
varonix0 merged 1 commit into
mainfrom
daniel/add-windows-docker-file
Oct 14, 2025
Merged

fix: add missing windows docker file#35
varonix0 merged 1 commit into
mainfrom
daniel/add-windows-docker-file

Conversation

@varonix0
Copy link
Copy Markdown
Member

Description 📣

Added missing windows docker file for docker image release.

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

@varonix0 varonix0 merged commit 2a1b177 into main Oct 14, 2025
3 checks passed
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

This PR restores the missing docker/windows Dockerfile that was accidentally removed in a previous revert. The file is required by .goreleaser-windows.yaml:17 to build Windows Docker images for the CLI.

Key points:

  • The Dockerfile uses the minimal nanoserver:ltsc2022 base image, which is appropriate for a Go CLI binary
  • The entrypoint correctly uses Windows-style path syntax (C:\\infisical.exe)
  • The file matches the original implementation from commit 5fdac4a
  • This fixes the broken Windows Docker image release pipeline introduced in PR #34

Confidence Score: 5/5

  • This PR is safe to merge - it simply restores a required file that was accidentally deleted
  • The change is minimal and necessary: it adds back a 3-line Dockerfile that was removed in a previous revert. The file is required by the goreleaser-windows configuration and matches the original implementation. There are no logic changes, security concerns, or potential bugs.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
docker/windows 5/5 Added missing Windows Dockerfile with minimal nanoserver base image and correct entrypoint configuration

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Actions
    participant GR as GoReleaser
    participant DF as docker/windows
    participant DH as Docker Hub
    
    Note over GH,DH: Windows Release Pipeline
    
    GH->>GH: Trigger on git tag (v*.*.*)
    GH->>GH: Run goreleaser-windows job
    GH->>GR: Execute with .goreleaser-windows.yaml
    GR->>GR: Build Windows binary (infisical.exe)
    GR->>DF: Use dockerfile: docker/windows
    DF->>DF: FROM nanoserver:ltsc2022
    DF->>DF: COPY infisical.exe
    DF->>DF: Set ENTRYPOINT
    GR->>DH: Push infisical/cli:X.Y.Z-windows-amd64
    GR->>DH: Push infisical/cli:latest-windows-amd64
Loading

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants