feat: add mysql account support#6917
Conversation
|
💬 Discussion in Slack: #pr-review-infisical-6917-feat-add-mysql-account-support Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
|
| Filename | Overview |
|---|---|
| backend/src/ee/services/pam-account/pam-account-schemas.ts | Adds MySQL account type schema with connection details and credentials validation; includes a dead .transform() on the database field and an unvalidated host field that could reach internal network targets through the gateway. |
| backend/src/ee/services/pam-session/pam-session-service.ts | Small, correct change: extends the database metadata population to cover MySQL alongside Postgres, with a proper presence check. |
Reviews (1): Last reviewed commit: "feat: add mysql account support" | Re-trigger Greptile
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b2c48be37
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Context
This PR adds MySQL support in PAM
Screenshots
Steps to verify the change
Type
Checklist
type(scope): short description(scope is optional, e.g.,fix: prevent crash on syncorfix(api): handle null response).