[CHORE] final v1.16 alignment for release #390
Conversation
…n (chain v1.16.0 and indexer v1.16.54). Updated ofac list.
WalkthroughThis update finalizes the release to version 1.11.0, updating version numbers in configuration and documentation. It introduces new protobuf and gRPC support for the Injective Megavault service and adds an Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant ArchiverRPCServer
Client->>ArchiverRPCServer: AccountStats(AccountStatsRequest)
ArchiverRPCServer-->>Client: AccountStatsResponse
sequenceDiagram
participant Client
participant MegavaultRPCServer
Client->>MegavaultRPCServer: GetVault(GetVaultRequest)
MegavaultRPCServer-->>Client: GetVaultResponse
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Pull Request Overview
This PR finalizes the v1.16 mainnet upgrade alignment by updating proto definitions and version tags to their stable release versions. The changes ensure the Python SDK is ready for the v1.16.0 mainnet release.
Key changes include:
- Updated version from "1.11.0-rc6" to stable "1.11.0" release
- Upgraded proto definitions to mainnet versions (chain v1.16.0 and indexer v1.16.54)
- Added new Megavault RPC service and AccountStats functionality
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updated package version from release candidate to stable version |
| pyinjective/proto/exchange/injective_megavault_rpc_pb2_grpc.py | Added new generated gRPC service for Megavault functionality |
| pyinjective/proto/exchange/injective_megavault_rpc_pb2.py | Added new protocol buffer definitions for Megavault service |
| pyinjective/proto/exchange/injective_archiver_rpc_pb2_grpc.py | Extended archiver service with AccountStats method |
| pyinjective/proto/exchange/injective_archiver_rpc_pb2.py | Updated archiver proto with AccountStats request/response types |
| buf.gen.yaml | Updated injective-core tag from beta to stable release |
| Makefile | Updated injective-indexer version from v1.16.20 to v1.16.54 |
| CHANGELOG.md | Updated release date and version for the v1.11.0 release |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
buf.gen.yaml (1)
25-27: Pin proto source to a commit for reproducible builds.Using a moving tag (
v1.16.0) risks silent changes if the tag is force-updated. Prefer an immutable commit SHA:- - git_repo: https://github.com/InjectiveLabs/injective-core - tag: v1.16.0 + - git_repo: https://github.com/InjectiveLabs/injective-core + commit: <insert_exact_sha_from_v1.16.0_tag>
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (8)
CHANGELOG.md(1 hunks)Makefile(1 hunks)buf.gen.yaml(1 hunks)pyinjective/proto/exchange/injective_archiver_rpc_pb2.py(2 hunks)pyinjective/proto/exchange/injective_archiver_rpc_pb2_grpc.py(4 hunks)pyinjective/proto/exchange/injective_megavault_rpc_pb2.py(1 hunks)pyinjective/proto/exchange/injective_megavault_rpc_pb2_grpc.py(1 hunks)pyproject.toml(1 hunks)
🔇 Additional comments (11)
pyproject.toml (1)
3-3: Version bump looks consistent, but verify other version holders.
pyproject.tomlnow advertises1.11.0. Double-check that any hard-coded__version__attributes (e.g.pyinjective/__init__.py) and packaging metadata on PyPI are bumped in lock-step to avoid mismatch warnings when users import the library.pyinjective/proto/exchange/injective_megavault_rpc_pb2.py (1)
1-11: Generated file detected – skipping manual review.File is auto-generated by
protoc; manual style/logic review is unnecessary. Ensure it remains excluded from lint, formatting, and coverage scopes (already covered by theflakeheaven/blackexclusion forpyinjective/proto/*).pyinjective/proto/exchange/injective_megavault_rpc_pb2_grpc.py (1)
25-34: Servicer method intentionally unimplemented.
InjectiveMegavaultRPCServicer.GetVaultcurrently raisesNotImplementedError, which is expected for generated stubs. No action required unless server implementation is planned within this repo.CHANGELOG.md (1)
5-16: Changelog entry aligns with release tag – LGTM.New section correctly documents 1.11.0 features and date; matches
pyproject.toml.Makefile (1)
34-34: LGTM! Version alignment is correct.The update to indexer version
v1.16.54aligns with the PR objectives for the v1.16 mainnet upgrade preparation.pyinjective/proto/exchange/injective_archiver_rpc_pb2.py (2)
17-17: LGTM! Generated protobuf code is correctly updated.The DESCRIPTOR contains the updated serialized protobuf schema with the new AccountStats messages. This is auto-generated code that correctly reflects the schema changes.
31-80: LGTM! Serialization offsets correctly updated.The addition of
AccountStatsRequestandAccountStatsResponsemessages has correctly shifted all subsequent message serialization offsets. The generated code maintains proper structure and offset calculations.pyinjective/proto/exchange/injective_archiver_rpc_pb2_grpc.py (4)
23-27: LGTM! Client stub correctly implements AccountStats RPC.The new
AccountStatsmethod is properly registered as a unary-unary RPC with correct serializers and deserializers matching the protobuf message types.
81-86: LGTM! Server servicer has proper placeholder implementation.The
AccountStatsmethod includes the standard UNIMPLEMENTED status and NotImplementedError, which is appropriate for generated gRPC servicer code.
152-156: LGTM! RPC method handler correctly configured.The
AccountStatshandler is properly mapped with correct request deserializer and response serializer functions.
236-261: LGTM! Experimental API method properly implemented.The static
AccountStatsmethod follows the same pattern as other RPC methods and includes all necessary gRPC call parameters with correct serialization functions.
Summary by CodeRabbit
New Features
Chores