Release/v1.11 for chain v1.16 #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aarmoa
commented
Jul 28, 2025
aarmoa
commented
- Release v1.11.0 with full support for chain upgrade v1.16
…xed all failing tests
…include new V2 chain stream protos. Fixed all failing tests
…ies and messages. Added tests for the deprecated V1 methods. Updated all example scripts related to Exchange module
…lient to get markets from the chain. Removed logic in Composer to load markets and tokens from the denom INI files
…e not going to include that in chain core
…o feat/add_support_exchange_v2
…o feat/add_support_exchange_v2
…d the extra digits in the amounts
…ccount_orders_message fix/rename_derivative_subaccount_orders_message
* feat: updated changelog and version number for v1.9.0 release * fix: updated the oracle stream prices script to send the oracle type always in lowercase * fix: added quantization in the functions that convert notional values to chain format * cp-235: updated the gas limit estimator logic to reflect the new logic for gas heuristics in exchange module (chain v1.15) * cp-235: updated all proto definitions with the candidate indexer and chain core versions for v1.15 chain upgrade * feat: added a new message based fee calculator supporting the Exchange module gas heuristics * fix: fix broadcaster creation example scripts * fix: pointed to the correct injective-core branch for the proto generation * fix: updated gas heuristics per message gas cost to sync with latest changes on chain * fix: added cleanup code in AsyncClient for the object destruction phase * feat: updated proto definitions for chain v1.15 upgrade and Indexer v1.14.48 * feat: made the gas calculator using gas heuristics the default one for the MsgBroadcasterWithPk when broadcasting without simulation * fix: fixed gas calculation using heuristics to not duplicate the required gas for post only orders
…into fix/rebase_dev_with_v1_10
Fix/rebase dev with v1.10
…o feat/add_support_exchange_v2
…mator using heuristics include GTB orders
Feat/add support exchange v2
…cuted in Windows machines
[CP-396] Add support for v1.16
…ge v2 endpoints. The original Composer and AsyncClient are still supported. Created an IndexerClient for all indexer endpoints
… Exchange module V2 queries and types. Updated examples and tests.
…or_exchange_v2_endpoints [CP-446] created v2 client for exchange v2 endpoints
[chore] fix example scripts
…ket_endpoint [chore] add positions in market endpoint
fix: renamed market modules
feat/add unique token symbol
…dable in Token class
…nction_in_token Feat/add human readable function in token
…n_from_eth [CP-508] add address creation from eth
…n (chain v1.16.0 and indexer v1.16.54). Updated ofac list.
…t_for_release [CHORE] final v1.16 alignment for release
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 93 files out of 300 files are above the max files limit of 200. You can disable this status message by setting the ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the pyinjective SDK to version 1.11.0 with support for chain upgrade v1.16. The changes primarily focus on migrating example code from using AsyncClient to newer client versions and updating usage patterns to align with the latest SDK architecture.
- Migration from
AsyncClienttoIndexerClientfor data fetching operations - Updates to client imports from
async_clienttoasync_client_v2andindexer_client - Introduction of
MsgBroadcasterWithPkfor transaction handling with improved gas estimation - Consistent output formatting using JSON pretty-printing across examples
Reviewed Changes
Copilot reviewed 299 out of 600 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Multiple oracle_rpc examples | Migrated from AsyncClient to IndexerClient and added JSON output formatting |
| Multiple meta_rpc examples | Updated client imports and standardized JSON response formatting |
| Multiple insurance_rpc examples | Switched to IndexerClient and improved output display |
| Multiple explorer_rpc examples | Updated to use IndexerClient with consistent JSON formatting |
| Multiple derivative_exchange_rpc examples | Migrated client usage and enhanced output readability |
| Multiple auctions_rpc examples | Updated client imports and JSON formatting |
| Multiple accounts_rpc examples | Switched to IndexerClient with improved output |
| Chain client examples | Migrated to async_client_v2 and MsgBroadcasterWithPk for transaction handling |
| Query examples | Updated imports from async_client to async_client_v2 |
Comments suppressed due to low confidence (3)
examples/chain_client/wasm/1_MsgExecuteContract.py:51
- The method name should follow snake_case convention. Use
msg_execute_contractinstead ofMsgExecuteContractto be consistent with the updated pattern shown in line 51 where it's changed to the snake_case version.
msg = composer.msg_execute_contract(
examples/chain_client/tokenfactory/5_MsgSetDenomMetadata.py:27
- The method
new_without_simulationis being changed tonew_using_gas_heuristicswhich suggests a different approach to gas estimation. Ensure this change is intentional and aligns with the new SDK patterns.
message_broadcaster = MsgBroadcasterWithPk.new_using_gas_heuristics(
examples/chain_client/tokenfactory/4_MsgChangeAdmin.py:27
- Similar to other files, the method is being changed from
new_without_simulationtonew_using_gas_heuristics. This pattern change should be consistent across all transaction examples.
message_broadcaster = MsgBroadcasterWithPk.new_using_gas_heuristics(
| oracle_base="Frontrunner", | ||
| oracle_quote="Frontrunner", | ||
| oracle_type=11, | ||
| oracle_type="Band", |
There was a problem hiding this comment.
The oracle_type parameter is being changed from a numeric value (11) to a string ("Band"). This could be a breaking change in the API. Verify that the new SDK version expects string values for oracle types.
Suggested change
| oracle_type="Band", | |
| oracle_type=11, # Updated to numeric value as required by the SDK |
Copilot uses AI. Check for mistakes.
| sender=address.to_acc_bech32(), | ||
| denom="INJ", | ||
| denom="inj", |
There was a problem hiding this comment.
The denom parameter is being changed from "INJ" to "inj". This change in casing could affect compatibility. Ensure this change aligns with the expected denomination format in the new SDK version.
Suggested change
| denom="inj", | |
| denom="INJ", |
Copilot uses AI. Check for mistakes.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.