Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 1, 2025

This PR resolves the GitHub Actions failures that were affecting all PRs, regardless of their content. The issue was caused by outdated action versions and a bug in the i18n consistency check workflow.

Problems Fixed

1. Outdated actions/checkout versions

Multiple workflows were using deprecated versions of actions/checkout (v2 and v3) which have known security vulnerabilities and compatibility issues with newer GitHub runners:

  • main.yml was using actions/checkout@v2
  • learning-path.yml was using actions/checkout@v2
  • i18n-consistency-check.yml was using actions/checkout@v2
  • links-fail-fast.yml was using actions/checkout@v3

2. Undefined variable in i18n workflow

The i18n-consistency-check.yml workflow referenced an undefined variable $i18n_last_update_hash on line 70, causing runtime failures when the workflow attempted to generate GitHub issue links.

3. Missing build artifact handling

The .gitignore file wasn't configured to handle temporary build files that could be accidentally committed during development or CI runs.

Changes Made

  • Updated all workflows to use actions/checkout@v4 for consistency, security, and compatibility
  • Fixed the undefined variable bug by adding the missing line to capture the translated file's commit hash:
    i18n_last_update_hash=$(git log -1 --format=%H $i18n_filename)
  • Enhanced .gitignore to prevent accidental commits of build artifacts like *.deb and *.tar.gz files

Testing

  • ✅ Hugo builds successfully with all language variants
  • ✅ i18n file generation process works correctly
  • ✅ All workflow syntax is valid
  • ✅ No existing functionality was broken

These minimal changes should resolve the GitHub Actions failures that were preventing PRs from passing their required checks.

Original prompt

This section details on the original issue you should resolve

<issue_title>GitHub actions should pass</issue_title>
<issue_description>Describe the bug
Every PR is getting GitHub action failures (nothing to do with PR contents)

Expected behavior
Empty PR should have all action successes.

Additional context
If the checks are finding something legitimate then fix whatever they are finding. If there checks don’t make sense then change the checks.
</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #1101

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] GitHub actions should pass Fix GitHub Actions failures by updating checkout versions and fixing i18n workflow bug Oct 1, 2025
Copilot AI requested a review from rrrutledge October 1, 2025 13:59
Copilot finished work on behalf of rrrutledge October 1, 2025 13:59
@rrrutledge
Copy link
Contributor

Why so many files changed? Can you break this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub actions should pass

2 participants