Skip to content

🐛 Fixed unfree packages not allowed in nix package #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xaiyadev wants to merge 24 commits into from
Closed

🐛 Fixed unfree packages not allowed in nix package #12

xaiyadev wants to merge 24 commits into from

Conversation

@xaiyadev
Copy link
Contributor

@xaiyadev xaiyadev commented May 27, 2025

A small bug that I not found until because it will not show in dev mode...
Just found out when I tried to install it on my machine :/

Also updated the sha256 for the packages

xaiyadev and others added 23 commits May 11, 2025 21:45
@xaiyadev
✨🚧 - Added nix packages with some bugs
a981d90 
Signed-off-by: Xaiya Schumin <[email protected]>
@Inrixia
Ensure liveReload is disabled on load
985a028
@Inrixia
Expose MediaItem.availableTags
6c1fdce
@Inrixia
LunaButtonSetting use props.title if children undefined
98b7912
@Inrixia
LunaStore fix support for spaces in plugin names
576706a
@Inrixia
Fix TidalApi.albumItems/Album.mediaItems
b2b52a7
@Inrixia
Improve MediaItem date parsing for releaseDate
5d51cdf
@Inrixia
Add unloads to observable
c4f8bd7
@Inrixia
Fix missing unloads for observe in @luna/lib
f8c3d63
@xaiyadev
✨ - Software is now builded in git - Version will now be updated in w…
902ae5d 
…orkflow

Signed-off-by: Xaiya Schumin <[email protected]>
@Inrixia
Fix missing unloads for ContextMenu observePromise
205dcf9
@Inrixia
@luna/ui properly indicate when plugins are loaded from dev url
0340fde
@Inrixia
Show version/dev in plugin header
3470ee4
@Inrixia
Add @jxnxsdev & @wont-stream stores
e398a8e
@Inrixia
Fix MediaItem.contentType undefined
c0d6753
@xaiyadev
Merge branch 'Inrixia:master' into master
1f8a303
@xaiyadev
🐛🚀 Fixed install hook, now using postInstall which will not break things
a4f0f06 
Signed-off-by: Xaiya Schumin <[email protected]>
@xaiyadev
🧑‍💻🔨 - Changed injection version for developing - Added devenv
74ebdd9 
Signed-off-by: Xaiya Schumin <[email protected]>
@xaiyadev
🙈 Update ignore for result
cdd77bc 
Signed-off-by: Xaiya Schumin <[email protected]>
@xaiyadev
✨ tempPath now in tempDir
588e55c 
Signed-off-by: Xaiya Schumin <[email protected]>
@xaiyadev
📦️ Fixed package.nix versioning and updated package version
c245a14 
Signed-off-by: Xaiya Schumin <[email protected]>
@xaiyadev
📝 added install instruction for nixos
b215bb8 
Signed-off-by: Xaiya Schumin <[email protected]>
@xaiyadev
🐛 Fixed unfree packages not allowed
dece5a8 
Signed-off-by: Xaiya Schumin <[email protected]>
@github-actions github-actions bot changed the base branch from master to dev May 27, 2025 14:19
@github-actions
Copy link

github-actions bot commented May 27, 2025

Your PR's base branch was set to master, PRs should be set to target the dev branch.
The base branch of this PR has been automatically changed to dev, please check that there are no merge conflicts

@xaiyadev
Copy link
Contributor Author

xaiyadev commented May 27, 2025

Also fixed some things that would have gotten us in trouble in the pipeline
Again sorry for not finding these bugs in the first time and my sloppy work :(

But now, this should do the trick

Looked over some things, installed it on my system... There should really be no major problem anymore!

@Inrixia
Copy link
Owner

Inrixia commented May 27, 2025

Can you sync your fork up with my master to fix the bajillion commits this has hanging off it ❤️

@xaiyadev
Copy link
Contributor Author

xaiyadev commented May 28, 2025

I forked it from your master but your bot always reverts it to the the dev branch...

@Inrixia
Copy link
Owner

Inrixia commented May 28, 2025

Ah ofc ugh. Yea that's on me I should be meeting dev up to date with master.

I'll sort this thx for letting me know

@xaiyadev
Copy link
Contributor Author

xaiyadev commented May 30, 2025 •
edited
Loading

Can this be merged? :>
The only changes are in nix and .github-workflows

If you like I could re-open a pull request

@Inrixia
Copy link
Owner

Inrixia commented May 30, 2025

Please fix the commit nightmare, you may need to redo your branch. Once its not a mess Ill merge.

@xaiyadev xaiyadev mentioned this pull request May 30, 2025
Merged
@xaiyadev
Copy link
Contributor Author

xaiyadev commented May 30, 2025

#18 replaces this

@xaiyadev xaiyadev closed this May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xaiyadev @Inrixia