-
-
Notifications
You must be signed in to change notification settings - Fork 35
✨ Added nix package #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Xaiya Schumin <d.schumin@proton.me>
|
Your PR's base branch was set to |
Yes, but only if you are OK with not being able to update within the client as the client needs write perms on the folder to do so. |
I would love that! Or maybe add some sort of try/catch that checks if you have read permissions and work with that then (first check if the home config folder where we would store the data has write access, if not resort to the opt/folder? That way we could add a module system into nix too! |
ATM its using the app dir because its there and simple. But changing that to the OS temp dir is better and something I was planning to do anyway. Doing that should remove any issues with needing fs write. |
Wouldn't it be smarter than to add it into the home config? |
|
The temp dir used only has files appear momentarily they are writtern, read and deleted immediately. So moving is to OS tmp makes the most sense. |
|
Hey, sorry been busy. Did you get the chance to review my last review comment? |
Yes, been busy myself lately I could, for the mean time, add something sloppy that would work, but is not really beatiful |
|
Ah great 😊 and no problem or rush, just checking in. Def get something you are happy with there's no need to push it out quickly. Appreciate the help and effort on this too! |
…orkflow Signed-off-by: Xaiya Schumin <d.schumin@proton.me>
|
This is looking awesome |
|
Lmk when it's ready to merge and we can test if the workflow properly updates the file |
|
Last things missing:
NixOS module needs the fix for the Entry thingy we talked about |
Signed-off-by: Xaiya Schumin <d.schumin@proton.me>
Signed-off-by: Xaiya Schumin <d.schumin@proton.me>
Signed-off-by: Xaiya Schumin <d.schumin@proton.me>
|
FYI (idm since I can just squash it or whatever) but for future prs it can be a good idea to make a new seperate branch on your repo so you don't run into pulling commits from a remote branch into the pr :) |
|
Yeah, already noticed that when it was to late |
Signed-off-by: Xaiya Schumin <d.schumin@proton.me>
Signed-off-by: Xaiya Schumin <d.schumin@proton.me>
Signed-off-by: Xaiya Schumin <d.schumin@proton.me>
|
Will add the modules part later in another pull request |
|
(Also added devenv files, making that I have the right packages for developing, if you dont want them in your repo I can remove them) |
Inrixia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diff is really messy due to mixed dev commits. Could you try merge dev into your branch, to isolate out just your changes. Or make a new branch and change this pr to use that ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bring this file back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll trust this is clear enough for the average nix user.
Fixes - #4
__Luna.registerNative': Error: EROFS: read-only file system
When creating a package with NixOS it is stored in
/nix/store, that folder is completely read-onlyThis software now tries to change some files that are now in the store...
Is there a way to move the files that needs to be edited in a
/tmpfolder or in the home directory itself?Or is there any other suggestion to fix this error?