Skip to content

Conversation

@xaiyadev
Copy link
Contributor

@xaiyadev xaiyadev commented May 11, 2025

Fixes - #4


  • __Luna.registerNative': Error: EROFS: read-only file system
  • Add GitHub workflow for flake update
  • (not big deal) Create modules for nix
  • Add documentation for installation in nix

__Luna.registerNative': Error: EROFS: read-only file system

When creating a package with NixOS it is stored in /nix/store, that folder is completely read-only
This software now tries to change some files that are now in the store...

Is there a way to move the files that needs to be edited in a /tmp folder or in the home directory itself?
Or is there any other suggestion to fix this error?

Signed-off-by: Xaiya Schumin <d.schumin@proton.me>
@github-actions github-actions bot changed the base branch from master to dev May 11, 2025 19:52
@github-actions
Copy link

Your PR's base branch was set to master, PRs should be set to target the dev branch.
The base branch of this PR has been automatically changed to dev, please check that there are no merge conflicts

@Inrixia
Copy link
Owner

Inrixia commented May 11, 2025

Is there a way to move the files that needs to be edited in a /tmp folder or in the home directory itself? Or is there any other suggestion to fix this error?

Yes, but only if you are OK with not being able to update within the client as the client needs write perms on the folder to do so.

@Inrixia Inrixia changed the base branch from dev to master May 12, 2025 00:19
@github-actions github-actions bot changed the base branch from master to dev May 12, 2025 00:19
Repository owner deleted a comment from github-actions bot May 12, 2025
@Inrixia Inrixia changed the base branch from dev to master May 12, 2025 00:23
@github-actions github-actions bot changed the base branch from master to dev May 12, 2025 00:23
Repository owner deleted a comment from github-actions bot May 12, 2025
@xaiyadev
Copy link
Contributor Author

Is there a way to move the files that needs to be edited in a /tmp folder or in the home directory itself? Or is there any other suggestion to fix this error?

Yes, but only if you are OK with not being able to update within the client as the client needs write perms on the folder to do so.

I would love that!
A solution maybe would be to add some sort of reload button into the config page?

Or maybe add some sort of try/catch that checks if you have read permissions and work with that then (first check if the home config folder where we would store the data has write access, if not resort to the opt/folder?

That way we could add a module system into nix too!

@Inrixia
Copy link
Owner

Inrixia commented May 12, 2025

I would love that! A solution maybe would be to add some sort of reload button into the config page?
Filesystem write is only needed for loading native plugin code, which most don't need and is due to me just cheating to fix another issue.

ATM its using the app dir because its there and simple. But changing that to the OS temp dir is better and something I was planning to do anyway. Doing that should remove any issues with needing fs write.

@xaiyadev
Copy link
Contributor Author

I would love that! A solution maybe would be to add some sort of reload button into the config page?
Filesystem write is only needed for loading native plugin code, which most don't need and is due to me just cheating to fix another issue.

ATM its using the app dir because its there and simple. But changing that to the OS temp dir is better and something I was planning to do anyway. Doing that should remove any issues with needing fs write.

Wouldn't it be smarter than to add it into the home config?
That would always help with different users wanting different configurations

@Inrixia
Copy link
Owner

Inrixia commented May 12, 2025

The temp dir used only has files appear momentarily they are writtern, read and deleted immediately.

So moving is to OS tmp makes the most sense.

@Inrixia
Copy link
Owner

Inrixia commented May 15, 2025

Hey, sorry been busy. Did you get the chance to review my last review comment?

@xaiyadev
Copy link
Contributor Author

Hey, sorry been busy. Did you get the chance to review my last review comment?

Yes, been busy myself lately
Right now I am searching for a solution that does not use the hashes and builds the project in the flake
Struggling with that a bit, maybe will throw that away too

I could, for the mean time, add something sloppy that would work, but is not really beatiful

@Inrixia
Copy link
Owner

Inrixia commented May 15, 2025

Ah great 😊 and no problem or rush, just checking in.

Def get something you are happy with there's no need to push it out quickly.

Appreciate the help and effort on this too!

…orkflow

Signed-off-by: Xaiya Schumin <d.schumin@proton.me>
@Inrixia
Copy link
Owner

Inrixia commented May 20, 2025

This is looking awesome

@Inrixia
Copy link
Owner

Inrixia commented May 20, 2025

Lmk when it's ready to merge and we can test if the workflow properly updates the file

@xaiyadev
Copy link
Contributor Author

Last things missing:

  • NixOS Modules
  • Documentation entry

NixOS module needs the fix for the Entry thingy we talked about
And I would write the documentation after I am done with the nixos Module

xaiyadev added 4 commits May 26, 2025 16:09
Signed-off-by: Xaiya Schumin <d.schumin@proton.me>
Signed-off-by: Xaiya Schumin <d.schumin@proton.me>
@Inrixia
Copy link
Owner

Inrixia commented May 26, 2025

FYI (idm since I can just squash it or whatever) but for future prs it can be a good idea to make a new seperate branch on your repo so you don't run into pulling commits from a remote branch into the pr :)

@xaiyadev
Copy link
Contributor Author

Yeah, already noticed that when it was to late
Will do that for my next PRs

xaiyadev added 2 commits May 27, 2025 10:47
Signed-off-by: Xaiya Schumin <d.schumin@proton.me>
Signed-off-by: Xaiya Schumin <d.schumin@proton.me>
Signed-off-by: Xaiya Schumin <d.schumin@proton.me>
@xaiyadev
Copy link
Contributor Author

Will add the modules part later in another pull request
So this can be merged!

@xaiyadev xaiyadev marked this pull request as ready for review May 27, 2025 09:03
@xaiyadev
Copy link
Contributor Author

(Also added devenv files, making that I have the right packages for developing, if you dont want them in your repo I can remove them)

Copy link
Owner

@Inrixia Inrixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff is really messy due to mixed dev commits. Could you try merge dev into your branch, to isolate out just your changes. Or make a new branch and change this pr to use that ❤️

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bring this file back

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll trust this is clear enough for the average nix user.

@xaiyadev xaiyadev closed this May 27, 2025
@Inrixia Inrixia reopened this May 27, 2025
@Inrixia Inrixia changed the base branch from dev to nixos May 27, 2025 11:38
@Inrixia Inrixia merged commit 7f9233c into Inrixia:nixos May 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants