Update HDF from 1.12.1 to 1.12.3 (2nd attempt) #4716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code extracted from:
https://github.com/HDFGroup/hdf5.git
at commit 106fb56936d1d785ca96147601a3608e433ddc3b (hdf5-1_12_3).
# By HDF5 Maintainers * upstream-HDF5: HDF5 2023-11-06 (106fb569) # Conflicts: # Modules/ThirdParty/HDF5/src/itkhdf5/CMakeFilters.cmake # Modules/ThirdParty/HDF5/src/itkhdf5/CMakeLists.txt # Modules/ThirdParty/HDF5/src/itkhdf5/config/cmake/ConfigureChecks.cmake # Modules/ThirdParty/HDF5/src/itkhdf5/config/cmake/HDFCompilerFlags.cmake # Modules/ThirdParty/HDF5/src/itkhdf5/config/cmake/HDFMacros.cmake # Modules/ThirdParty/HDF5/src/itkhdf5/config/cmake_ext_mod/ConfigureChecks.cmake # Modules/ThirdParty/HDF5/src/itkhdf5/config/cmake_ext_mod/HDFUseCXX.cmake # Modules/ThirdParty/HDF5/src/itkhdf5/hl/CMakeLists.txt # Modules/ThirdParty/HDF5/src/itkhdf5/src/CMakeLists.txt
|
Note: once CI is green, the symbols will also need to be per itk_hdf5_mangle.h.in. |
Hopefully next week I'll have time to try this again, on top of 5.4 branch. |
|
Superceeded by #4940 |
What in particular to you want to ensure is in this PR? That other PR, was not building correctly, and this PR makes an effort to remove changes from the HDF5 code base. |
|
I just wanted to ensure that this PR references the other one as context since they both seem to be addressing the same update desire. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.