Double convert 3.3.0

[blowekamp]

PR Checklist

• No API changes were made (or the changes have been approved)
• No major design changes were made (or the changes have been approved)
• Added test (or behavior not changed)
• Updated API documentation (or API not changed)
• Added license to new files (if any)
• Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
• Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

[blowekamp]

@dzenanz I had to manually restore a couple files from before the Update script was run. Do you have an example of how those files can remain? How could the Update script be modified to do so?

[dzenanz]

Restored how? I guess that should be accomplished by commands in the short script here:
https://github.com/InsightSoftwareConsortium/ITK/blob/v5.4.0/Modules/ThirdParty/DoubleConversion/UpdateDoubleConversionFromGoogle.sh#L21

[dzenanz]

Mark as ready? And merge?

[blowekamp]

I did a git checkout HEAD~2 src/double-conversion/src/double-conversion-configure.h.in src/double-conversion/CMakeLists.txt and amended to the merge. I am not clear on the environment that the update script operates in to change it to preserve these files.

[dzenanz]

@bradking might have advice.

[hjmjohnson]

Updating this package is such a rare occurrence that I think we could merge this PR as is.

[bradking]

It looks like the previous import was done incorrectly, and it's confusing the script. I'll try to build a fixed history.

[bradking]

@blowekamp @dzenanz I updated this PR to rebuild the import with corrected history. It looks like the previous import brought the changes already, so this just fixes history so that the next import can succeed.

[bradking]

Also, be sure that this is not merged with GitHub's squash merge feature. That will erase the corrected history structure.

[dzenanz]

OK, so merge commit or manual push to master.

[dzenanz]

For posterity (in case someone is curious), #4567 was merged via "Rebase and merge" resulting in 3dcbf20.

[bradking]

Yes, I recommend merging with a dedicated merge commit rather than a direct push fast-forwarding master. Certainly no rebase or squash.