-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update demo to Expo SDK 52 #1072
Open
flochtililoch
wants to merge
17
commits into
master
Choose a base branch
from
florent/update-demo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps getting the latest Hyperview changes into CI, before cutting a release. It is also helpful to have the changes from master deployed before a release.
…d moving homepage/private to match position in file with generated file
The demo at `Behaviors > Triggers > Back` frequently re-triggers. This same demo appears also at `Navigation > Behaviors > Triggers > Back`. This version includes a delay on the `back` action to ensure the `hide` has completed. This delay was ported to fix the issue. | Before | After | | -- | -- | |  |  | [Asana](https://app.asana.com/0/1204008699308084/1209227756307892)
New version of datepicker no longer auto center - this fix forces it back in the center of the picker modal. This PR also cleans up duplication on the demo styles for the picker modal. | Before | After | |--|--| |  |  | --------- Co-authored-by: flochtililoch <[email protected]>
Explicitly set an arbitrary maximum date to work around an iOS bug, where the date picker will not allow a selection after another date picker with a max date was rendered. https://app.asana.com/0/1204008699308084/1209403666139698 | Before | After | |--|--| |  |  | Co-authored-by: flochtililoch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate update instructions into a script, and run it.
Testing still in progress, there are new regressions around navigation, date picker and more that will need to be investigated.
https://app.asana.com/0/1204008699308084/1209103436957309/f