Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update demo to Expo SDK 52 #1072

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

flochtililoch
Copy link
Collaborator

Migrate update instructions into a script, and run it.

Testing still in progress, there are new regressions around navigation, date picker and more that will need to be investigated.

https://app.asana.com/0/1204008699308084/1209103436957309/f

Base automatically changed from florent/kb-aware-scrollview to master February 14, 2025 18:01
hgray-instawork and others added 3 commits February 14, 2025 16:36
The demo at `Behaviors > Triggers > Back` frequently re-triggers.

This same demo appears also at `Navigation > Behaviors > Triggers >
Back`. This version includes a delay on the `back` action to ensure the
`hide` has completed. This delay was ported to fix the issue.

| Before | After |
| -- | -- |
|
![before](https://github.com/user-attachments/assets/80781a5f-0986-459d-9395-d9a72ae5acfa)
|
![after](https://github.com/user-attachments/assets/7eeaafac-f452-4890-b76a-473924a726df)
|

[Asana](https://app.asana.com/0/1204008699308084/1209227756307892)
New version of datepicker no longer auto center - this fix forces it
back in the center of the picker modal. This PR also cleans up
duplication on the demo styles for the picker modal.

| Before | After |
|--|--|
| ![Simulator Screenshot - iPhone 16 Pro - 2025-02-14 at 16 52
40](https://github.com/user-attachments/assets/31ee777f-47ef-47c8-92fa-db21e23d7745)
| ![Simulator Screenshot - iPhone 16 Pro - 2025-02-14 at 16 41
59](https://github.com/user-attachments/assets/d1e0b053-559a-4a00-bc9c-7ac494ab1977)
|

---------

Co-authored-by: flochtililoch <[email protected]>
Explicitly set an arbitrary maximum date to work around an iOS bug,
where the date picker will not allow a selection after another date
picker with a max date was rendered.

https://app.asana.com/0/1204008699308084/1209403666139698

| Before | After |
|--|--|
|
![before](https://github.com/user-attachments/assets/a93fa321-9a5c-4f16-84fa-c371a6b72294)
|
![after](https://github.com/user-attachments/assets/458fb835-1f88-47e5-8d80-f17426131d25)
|

Co-authored-by: flochtililoch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants