Files: ошибка учета удаленных файлов при подсчете в FilesCountLimiter#656
Open
Files: ошибка учета удаленных файлов при подсчете в FilesCountLimiter#656
Conversation
DedSec256
reviewed
Mar 8, 2026
| if (!existingStatuses.Succeeded) return false; | ||
|
|
||
| var existingIds = existingStatuses.Value.Select(f => f.Id).ToList(); | ||
| var existingIds = existingStatuses.Value.Where(f => f.Status == "ReadyToUse").Select(f => f.Id).ToList(); |
Contributor
There was a problem hiding this comment.
А почему не учитываются файлы в процессе загрузки или файлы, которые не удалось удалить?
Contributor
Author
There was a problem hiding this comment.
Жалко пользователя, который не может загрузить файлы из-за того что у нас не получилось прошлые удалить(((
Contributor
There was a problem hiding this comment.
Тогда, наверное, стоит разобраться, почему не получилось их удалить (или почему не отобразилось, что они в процессе удаления). Данное исправление выглядит некорректным
semrosin
force-pushed
the
files-to-solutions
branch
from
a8e4f8c to
47c6e8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.