Skip to content

Unmute FFT tests that are fixed #2523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

Unmute FFT tests that are fixed #2523

merged 1 commit into from
Jul 11, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jul 10, 2025

Unmute FFT tests that are fixed.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vtavana vtavana self-assigned this Jul 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 10, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.19.0dev1=py313h509198e_5 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Jul 10, 2025 •
edited
Loading

Coverage Status

coverage: 72.088%. remained the same
when pulling f0d9256 on remove-skip-fft-tests
into 9b73305 on master.

@vtavana vtavana force-pushed the remove-skip-fft-tests branch from f2ec152 to f0d9256 Compare July 10, 2025 19:41
@vtavana vtavana marked this pull request as ready for review July 10, 2025 20:40
@antonwolfy antonwolfy added this to the 0.19.0 release milestone Jul 11, 2025
antonwolfy
antonwolfy approved these changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana for updating the tests. LGTM!

@vtavana vtavana merged commit 425ec0c into master Jul 11, 2025
94 of 98 checks passed
@vtavana vtavana deleted the remove-skip-fft-tests branch July 11, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
0.19.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @coveralls @antonwolfy