Unify dpnp public API exports by refactoring __init__.py
#2666
+82
−64
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -66,9 +66,6 @@ | |||||
| from .dpnp_array import dpnp_array as ndarray | ||||||
| from .dpnp_array_api_info import __array_namespace_info__ | ||||||
| from .dpnp_flatiter import flatiter as flatiter | ||||||
| from ._version import get_versions | ||||||
| from . import exceptions as exceptions | ||||||
| from . import fft as fft | ||||||
|
|
@@ -77,6 +74,81 @@ | |||||
| from . import scipy as scipy | ||||||
|
|
||||||
|
|
||||||
| # ============================================================================= | ||||||
| # Data types, constants and type-related helpers | ||||||
| # ============================================================================= | ||||||
|
|
||||||
| # ----------------------------------------------------------------------------- | ||||||
| # Data types (borrowed from NumPy) | ||||||
| # | ||||||
| # The order of these declarations are borrowed from the NumPy document: | ||||||
| # https://numpy.org/doc/stable/reference/arrays.scalars.html | ||||||
|
Comment on lines
+84
to
+85
Contributor
There was a problem hiding this comment. It does not really make any sense, because there is a single
Contributor
There was a problem hiding this comment. The order is defined by the python sort linter and not by the pointing numpy's page. |
||||||
| # ----------------------------------------------------------------------------- | ||||||
| from .dpnp_iface_types import ( | ||||||
| bool, | ||||||
| bool_, | ||||||
| byte, | ||||||
| cdouble, | ||||||
| complex128, | ||||||
| complex64, | ||||||
| complexfloating, | ||||||
| csingle, | ||||||
| double, | ||||||
| dtype, | ||||||
| float16, | ||||||
| float32, | ||||||
| float64, | ||||||
| floating, | ||||||
| inexact, | ||||||
| int_, | ||||||
| int8, | ||||||
| int16, | ||||||
| int32, | ||||||
| int64, | ||||||
| integer, | ||||||
| intc, | ||||||
| intp, | ||||||
| longlong, | ||||||
| number, | ||||||
| short, | ||||||
| signedinteger, | ||||||
| single, | ||||||
| ubyte, | ||||||
| uint8, | ||||||
| uint16, | ||||||
| uint32, | ||||||
| uint64, | ||||||
| uintc, | ||||||
| uintp, | ||||||
| unsignedinteger, | ||||||
| ushort, | ||||||
| ulonglong, | ||||||
| ) | ||||||
|
|
||||||
| # ----------------------------------------------------------------------------- | ||||||
| # Constants (borrowed from NumPy) | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
|
||||||
| # ----------------------------------------------------------------------------- | ||||||
| from .dpnp_iface_types import ( | ||||||
| e, | ||||||
| euler_gamma, | ||||||
| inf, | ||||||
| nan, | ||||||
| newaxis, | ||||||
| pi, | ||||||
| ) | ||||||
|
Comment on lines
+131
to
+138
Contributor
There was a problem hiding this comment. It has to be a part of the below |
||||||
|
|
||||||
| # ----------------------------------------------------------------------------- | ||||||
| # Type-related helper functions | ||||||
| # ----------------------------------------------------------------------------- | ||||||
| from .dpnp_iface_types import ( | ||||||
|
Contributor
There was a problem hiding this comment. That is a part of |
||||||
| common_type, | ||||||
| finfo, | ||||||
|
Contributor
There was a problem hiding this comment. Do we need to move |
||||||
| iinfo, | ||||||
| isdtype, | ||||||
| issubdtype, | ||||||
| is_type_supported, | ||||||
|
Contributor
There was a problem hiding this comment. That needs to be moved away. It's a kind of deprecated API which we should not expose. |
||||||
| ) | ||||||
|
Contributor
There was a problem hiding this comment. It seems |
||||||
|
|
||||||
| # ============================================================================= | ||||||
| # Routines | ||||||
| # | ||||||
|
|
@@ -424,6 +496,11 @@ | |||||
| unwrap, | ||||||
| ) | ||||||
|
|
||||||
| # ----------------------------------------------------------------------------- | ||||||
| # Miscellaneous routines | ||||||
| # ----------------------------------------------------------------------------- | ||||||
| from .dpnp_iface_utils import byte_bounds | ||||||
|
|
||||||
| # ----------------------------------------------------------------------------- | ||||||
| # Sorting, searching, and counting | ||||||
| # ----------------------------------------------------------------------------- | ||||||
|
|
@@ -514,10 +591,8 @@ | |||||
| ) | ||||||
|
|
||||||
|
|
||||||
| # add submodules | ||||||
| __all__ = ["exceptions", "fft", "linalg", "random", "scipy"] | ||||||
|
|
||||||
|
|
||||||
| __version__ = get_versions()["version"] | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,8 +38,6 @@ | |
|
|
||
| import dpctl.tensor as dpt | ||
|
|
||
|
|
||
| def __array_namespace_info__(): | ||
| """ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,8 +37,6 @@ | |
|
|
||
| import dpnp | ||
|
|
||
|
|
||
| def byte_bounds(a): | ||
| """ | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove
"--disable=c-extension-no-member"from.pre-commit-config.yamlnow?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And E501 skipping in
.flake8