Skip to content

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Aug 13, 2025

address #5

@vtavana vtavana self-assigned this Aug 13, 2025
@vtavana vtavana marked this pull request as ready for review August 28, 2025 12:08
@Copilot Copilot AI review requested due to automatic review settings August 28, 2025 12:08
@vtavana vtavana requested a review from ekomarova as a code owner August 28, 2025 12:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Dask interface for the mkl_fft package, providing a drop-in replacement for the dask.fft module that leverages Intel MKL's optimized FFT implementations.

  • Implements mkl_fft.interfaces.dask_fft module with all FFT functions wrapped using Dask's fft_wrap
  • Adds comprehensive test suite for the new Dask interface functionality
  • Updates build configuration and documentation to support the new interface

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pyproject.toml Adds dask_interface optional dependency and includes dask in test dependencies
mkl_fft/interfaces/dask_fft.py New module implementing Dask FFT interface by wrapping numpy_fft functions
mkl_fft/tests/third_party/dask/test_dask_fft.py Comprehensive test suite for Dask FFT functionality
mkl_fft/tests/test_interfaces.py Updates interface tests to include Dask FFT
mkl_fft/interfaces/init.py Conditionally imports dask_fft module when Dask is available
mkl_fft/interfaces/README.md Adds documentation for the new Dask interface
conda-recipe/meta.yaml Updates conda recipe to include dask test dependency and import test
conda-recipe-cf/meta.yaml Updates conda-forge recipe similarly
CHANGELOG.md Documents the new Dask interface feature
.github/workflows/*.yml Updates CI workflows to include dask as test dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@IntelPython IntelPython deleted a comment from Copilot AI Aug 28, 2025
@IntelPython IntelPython deleted a comment from Copilot AI Aug 28, 2025
@IntelPython IntelPython deleted a comment from Copilot AI Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant