fix: execute Bukkit item use on the main thread - #3619
Closed
twme-ai wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run Bukkit item-use simulation on FAWE's synchronous task manager.
Problem
BukkitWorld.useItem()can be reached from FAWE's asynchronous executionpath. Paper's item-use implementation fires
BlockCanBuildEvent, which mustrun on the server thread, causing
BlockCanBuildEvent may only be triggered synchronously.The adapter call now follows the existing Bukkit integration convention and
uses
TaskManager.taskManager().sync(...).Testing
Also exercised on Paper 1.21.10 with a Mineflayer item-use brush: the expected
sapling was placed and Paper emitted no asynchronous Bukkit-event error.