Skip to content

Add option to disable module discovery #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add option to disable module discovery #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fcadf9
Add configuration option to prevent module autodiscovery
viicslen May 14, 2024
b5553b0
Merge branch 'main' into main
inxilpro Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
| ],
*/

'stubs' => null,
'stubs' => null,

/*
|--------------------------------------------------------------------------
Expand All @@ -90,5 +90,27 @@
| the presence of event discovery.
*/

'should_discover_events' => null,
'should_discover_events' => null,

/*
|--------------------------------------------------------------------------
| Prevent automatic discovery of module components
|--------------------------------------------------------------------------
|
| This package automatically discovers different componets from the modules
| like commands, routes, views, translations, blade and livewire
| components, and breadcrumbs. If you want to prevent automatic discovery
| of specific components you can list them here in the 'dont_discover'
| array.
*/

'dont_discover' => [
// 'commands',
// 'routes',
// 'views',
// 'translations',
// 'blade_components',
// 'livewire_components',
// 'breadcrumbs',
],
];
47 changes: 36 additions & 11 deletions src/Support/ModularServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,35 @@ public function register(): void

public function boot(): void
{
$this->publishVendorFiles();
$this->bootPackageCommands();

$this->bootRoutes();
$this->bootBreadcrumbs();
$this->bootViews();
$this->bootBladeComponents();
$this->bootTranslations();
$this->bootLivewireComponents();
$this->publishVendorFiles();

if ($this->shouldDiscover('commands')) {
$this->bootPackageCommands();
}

if ($this->shouldDiscover('routes')) {
$this->bootRoutes();
}

if ($this->shouldDiscover('breadcrumbs')) {
$this->bootBreadcrumbs();
}

if ($this->shouldDiscover('views')) {
$this->bootViews();
}

if ($this->shouldDiscover('blade_components')) {
$this->bootBladeComponents();
}

if ($this->shouldDiscover('translations')) {
$this->bootTranslations();
}

if ($this->shouldDiscover('livewire_components')) {
$this->bootLivewireComponents();
}
}

protected function registry(): ModuleRegistry
Expand All @@ -93,7 +113,12 @@ protected function registry(): ModuleRegistry
protected function autoDiscoveryHelper(): AutoDiscoveryHelper
{
return $this->auto_discovery_helper ??= $this->app->make(AutoDiscoveryHelper::class);
}
}

protected function shouldDiscover(string $component): bool
{
return ! in_array($component, config('app-modules.dont_discover', []));
}

protected function publishVendorFiles(): void
{
Expand All @@ -103,7 +128,7 @@ protected function publishVendorFiles(): void
}

protected function bootPackageCommands(): void
{
{
if (! $this->app->runningInConsole()) {
return;
}
Expand Down