-
Notifications
You must be signed in to change notification settings - Fork 551
[ci] add test workflow for 3090 machine #3561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for running tests on a 3090 machine by introducing new configuration flags, updating test annotations, and adding a dedicated workflow file. The key changes include:
- Injecting environment‑specific command line flags (e.g. “cache‑max‑entry‑count”) for the 3090 machine.
- Updating test functions to include a new @pytest.mark.test_3090 annotation.
- Adding a new daily ETE test workflow file and a dedicated 3090 configuration file.
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
autotest/utils/run_client_chat.py | Adds extra CLI flag when running on env '3090'. |
autotest/utils/quantization_utils.py | Adjusts batch-size logic for 3090 and applies conditional cuda_prefix usage. |
autotest/utils/pipeline_chat.py | Updates default parameter handling for extra and injects cache settings for 3090. |
autotest/utils/config_utils.py | Uses OrderedDict to remove duplicate model entries in quantization config. |
Various test files | Adds @pytest.mark.test_3090 annotations for tests targeting the 3090 machine. |
autotest/tools/pipeline/mllm_case.py & llm_case.py | Adds support for passing cache settings via extra configuration. |
autotest/config.yaml & config-3090.yaml | Introduces env_tag for distinguishing configurations. |
.github/workflows/daily_ete_test_3090.yml | New workflow configuration for daily testing on the 3090 machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for running test workflows on a 3090 machine by updating various test files, configuration files, and adding a new GitHub workflow. Key changes include:
- Inserting environment‐specific logic (checking for env_tag "3090") in the client, quantization, and pipeline modules.
- Adding new pytest marks (@pytest.mark.test_3090) to multiple test cases and updating configuration files to support 3090 settings.
- Introducing a new GitHub workflow file (.github/workflows/daily_ete_test_3090.yml) to orchestrate daily tests on the 3090 machine.
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
autotest/utils/run_client_chat.py | Added environment check for "3090" to adjust extra cli flags. |
autotest/utils/quantization_utils.py | Refactored command construction for quantization with environment-specific batch sizes. |
autotest/utils/pipeline_chat.py | Included test-specific overrides via env_tag "3090" and modified extra parameters for chat tests. |
autotest/utils/config_utils.py | Updated quantization model list construction to remove duplicate entries using OrderedDict. |
Various test files under autotest/tools | Added new pytest marker (@pytest.mark.test_3090) for 3090-targeted tests. |
autotest/config.yaml & autotest/config-3090.yaml | Introduced and updated env_tag settings to distinguish between standard and 3090 environments. |
.github/workflows/daily_ete_test_3090.yml | Added a comprehensive workflow to run daily E2E tests on the 3090 machine. |
Comments suppressed due to low confidence (1)
autotest/utils/pipeline_chat.py:33
- [nitpick] The extra parameter 'cache-max-entry-count' is set to different values across modules (e.g., 0.7 in run_client_chat, 0.6 and 0.5 in pipeline tests). Verify these values are intentionally different; if not, consider consolidating them to avoid confusion.
if str(config.get('env_tag')) == '3090':
add test workflow for 3090 machine