feat: configurable max_loop in build_kg

[ChenZiHong-Gavin]

This PR makes the max_loop parameter configurable in the knowledge graph building process, replacing a previously hardcoded value of 3 loops.

[gemini-code-assist]

Summary of Changes

Hello @ChenZiHong-Gavin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces enhanced flexibility to the knowledge graph construction process by externalizing the max_loop parameter. This change allows users to specify the maximum number of iterations for entity and relationship extraction, moving away from a fixed value and enabling fine-tuned control over the graph building process. The modification ensures that the max_loop setting is consistently passed from the service layer down to the core builder logic.

Highlights

• Configurable max_loop Parameter: The max_loop parameter, which dictates the maximum number of loops for entity and relationship extraction during knowledge graph building, is now configurable instead of being a hardcoded value of 3.
• BuildKGService Initialization Update: The BuildKGService class constructor now accepts **build_kwargs, allowing the max_loop value to be passed dynamically and stored as an instance attribute self.max_loop.
• build_text_kg Function Enhancement: The build_text_kg function has been updated to accept max_loop as an explicit argument, which is then used to initialize the LightRAGKGBuilder, ensuring the configurable value is applied.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully makes the max_loop parameter configurable for the knowledge graph building process, which is a good improvement over the previous hardcoded value. The changes are logical and correctly propagated from the service layer down to the KG builder. I have one suggestion to improve the robustness of handling the new configuration parameter to prevent potential crashes from invalid input.

[gemini-code-assist]

The direct conversion using int() can raise a ValueError if the max_loop value in build_kwargs is not a valid integer (e.g., an empty string or non-numeric text). This would cause the operator initialization to fail. It's safer to handle this potential error with a try-except block to ensure robustness, log a warning, and fall back to a default value.

Suggested change

	self.max_loop: int = int(self.build_kwargs.get("max_loop", 3))
	max_loop_val = self.build_kwargs.get("max_loop", 3)
	try:
	self.max_loop: int = int(max_loop_val)
	except (ValueError, TypeError):
	self.logger.warning(
	f"Invalid value for max_loop: '{max_loop_val}'. Using default value of 3."
	)
	self.max_loop = 3