-
Notifications
You must be signed in to change notification settings - Fork 63
tests: add e2e tests #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds comprehensive end-to-end (e2e) tests for the GraphGen tool, testing different output data types and standardizing the output directory structure.
- Creates e2e test files for atomic, aggregated, chain-of-thought, and multi-hop data generation
- Modifies output path structure to include the data type in the folder name
- Streamlines file organization by moving logs into the data directory and simplifying config file naming
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e_tests/test_generate_atomic.py | E2e test for atomic data generation with proper function naming |
| tests/e2e_tests/test_generate_aggregated.py | E2e test for aggregated data generation |
| tests/e2e_tests/test_generate_cot.py | E2e test for chain-of-thought data generation with misnamed function |
| tests/e2e_tests/test_generate_multi_hop.py | E2e test for multi-hop data generation with misnamed function |
| graphgen/graphgen.py | Updates output directory structure to include data type in path |
| graphgen/generate.py | Reorganizes output structure and simplifies config file naming |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
tests: add e2e tests
This PR adds comprehensive end-to-end (e2e) tests for the GraphGen tool, testing different output data types and standardizing the output directory structure.