refactor: refactor concurrent and add progress bar #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CHERRY-ui8
commented
Nov 20, 2025
CHERRY-ui8
commented
- Refactor judge.py to use run_concurrent instead of Semaphore
- Add progress_bar to judge_statement function and pre_tokenize function
…dard operator - Fix .pylintrc: comment out unsupported suggestion-mode option - Implement QuizGenerator class with proper BaseGenerator interface - Fix build_prompt parameter from 'description' to 'batch' to match parent class - Add build_prompt_for_description helper method for single description handling - Use DESCRIPTION_REPHRASING_PROMPT template instead of AGGREGATED_GENERATION_PROMPT - Refactor quiz.py to use QuizGenerator following standard operator pattern - Remove direct template and utility function dependencies - Use QuizGenerator class methods for prompt building and response parsing - Export QuizGenerator in model __init__ files This refactoring follows the same pattern as other operators (e.g., generate_qas.py) and makes the code more maintainable and consistent with the codebase architecture.
- Replace manual asyncio with run_concurrent utility - Fix language codes: English/Chinese -> en/zh - Add progress_bar support
- Add progress_bar parameter to judge_statement function - Refactor pre_tokenize to use run_concurrent with progress bar support - Refactor judge.py to use run_concurrent instead of manual semaphore management - Remove tqdm_async dependency in favor of run_concurrent utility
Contributor
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
CHERRY-ui8
pushed a commit
to CHERRY-ui8/GraphGen
that referenced
this pull request
Dec 17, 2025
…-bar-and-refactor-concurrent refactor: refactor concurrent and add progress bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.