Better implementation for probe_info.json update to prevent corruption (#32)#33
Open
HUDASULTANA wants to merge 1 commit into
Open
Conversation
5c9a752 to
11b3907
Compare
Author
|
@romain-fontugne, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the tools.py script updates probe_info.json by overwriting or deleting the existing cache. If the script fails mid-execution, the JSON file can be left missing or corrupted.
This PR implements a safer approach:
-Fetch first, save later: The new probe data is fetched from the RIPE API.
-Validate JSON: Before replacing the old cache, the new JSON is validated to ensure it is correctly formatted.
-Atomic cache replacement: Only after successful validation is the old probe_info.json replaced with the new one.
-Existing cache usage: If a valid cache already exists, it is used to avoid unnecessary API calls.
Notes: