Patch postgresql-setup.sh #1981
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgillespie
reviewed
Jun 13, 2025
| @@ -192,6 +192,7 @@ function restore_snapshot { | |||
| tar xvf "$1" --directory "$tmp_dir" | |||
| if test -d "${tmp_dir}/db/" ; then | |||
| # New pg_dump format | |||
| lstate_gz_file=$(find "${tmp_dir}/" -iname "*.lstate.gz") | |||
There was a problem hiding this comment.
Is this right? Would tar xvf "$1" --directory "$tmp_dir" put the archive in $tmp_dir?
There was a problem hiding this comment.
That's an existing line in the script, not part of the proposed changes but yes, tar with --directory parameter would step into $tmp_dir folder before commencing the extraction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Last update to this script accidentally seemed to have deleted an additional line that it wasnt supposed to. This resulted in lstate file not being restored in ledger-state directory, thereby - forcing a replay every time restore was done.
Checklist
fourmoluon version 0.10.1.0 (which can be run withscripts/fourmolize.sh)