Skip to content

CI ONLY (release branch) #5720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

CI ONLY (release branch) #5720

wants to merge 11 commits into from

Conversation

disassembler
Copy link
Contributor

Description

Add your description here, if it fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

coot and others added 8 commits April 9, 2024 10:44
Also updated `copyright` field in the `cardano-node.cabal` file.
Upgraded to `ouroboros-network-0.15.0.0`
Otherwise:

src/Cardano/Analysis/API/Ground.hs:58:13: error:
    Ambiguous occurrence ‘toText’
    It could refer to
       either ‘Cardano.Prelude.toText’,
              imported from ‘Cardano.Prelude’ at src/Cardano/Analysis/API/Ground.hs:14:1-53
              (and originally defined in ‘cardano-prelude-0.2.0.0:Cardano.Prelude.ConvertText’)
           or ‘Data.Text.Short.toText’,
              imported from ‘Data.Text.Short’ at src/Cardano/Analysis/API/Ground.hs:25:63-68
              (and originally defined in ‘text-short-0.1.5:Data.Text.Short.Internal’)
   |
58 | shortHash = toText . SText.take 6 . unHash
   |             ^^^^^^
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants