Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-testnet: harmonize node and genesis files API + allow (for example) to only pass a custom conway genesis #6138

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Mar 4, 2025

Description

Together with #6103 (6103 being stacked on this PR), this PR allows for the following:

Checklist

@smelc smelc force-pushed the smelc/per-genesis-file-origin branch 10 times, most recently from 24e09df to ad8dbd6 Compare March 10, 2025 14:10
@smelc smelc changed the title cardano-testnet: use one origin for each genesis file cardano-testnet: harmonize node and genesis files API + allow (for example) to only pass a custom conway genesis Mar 10, 2025
@smelc smelc marked this pull request as ready for review March 10, 2025 14:53
@smelc smelc requested a review from a team as a code owner March 10, 2025 14:53
@smelc smelc force-pushed the smelc/per-genesis-file-origin branch 2 times, most recently from 70c0e00 to 9cd0ae0 Compare March 11, 2025 15:07
@smelc smelc force-pushed the smelc/per-genesis-file-origin branch from 9cd0ae0 to 72ea5dc Compare March 11, 2025 18:45
@smelc smelc enabled auto-merge March 11, 2025 18:56
@smelc
Copy link
Contributor Author

smelc commented Mar 11, 2025

@IntersectMBO/performance-and-tracing> this PR removes the creation of the genesis spec files. Given that we now have a complex mechanism for genesis files being passed by the user or generated on demand, maintaining the creation of spec files is too complex on our side.

@smelc smelc added this pull request to the merge queue Mar 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants