-
Notifications
You must be signed in to change notification settings - Fork 730
Bump consensus and network dependencies in preparation for node 10.5 #6218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a644563
to
eba4ee3
Compare
geo2a
reviewed
May 19, 2025
35e835c
to
da6e572
Compare
15f6556
to
71cbda0
Compare
9 tasks
dabb676
to
eb033c1
Compare
eb033c1
to
15ea9ff
Compare
carbolymer
approved these changes
May 20, 2025
3918a03
to
4cf53a5
Compare
55c2c73
to
6e9a5c4
Compare
7852264
to
1acd745
Compare
The tracing system is modified to effectively ignore `HeaderWithTime` by dropping the time annotations and using the underlying `Header`, keeping the old behaviour.
Egress poll interval is configurable, and disabled by default.
When catching SIGTERM the node does a clean exit, but its exit status is 1. This makes it impossible to differentiate between a clean shutdown triggered by SIGTERM and a crash. This changes it so that cardano-node exits with 0 when exiting due to catching SIGTERM.
1acd745
to
bb96e9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add your description here, if it fixes a particular issue please provide a
link
to the issue.
Checklist
See Runnings tests for more details
CHANGELOG.md
for affected package.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-9.6
andghc-9.12
Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.