Skip to content

Remove internal trace types from the public API #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jorisdral
Copy link
Collaborator

They are hidden behind a debug flag now.

They are hidden behind a debug flag now.
@wenkokke
Copy link
Collaborator

wenkokke commented Jun 2, 2025

Honestly, it's probably fine to just not export the constructors from the main API. The internal modules are internal for a reason, so you shouldn't be using those.

@jorisdral
Copy link
Collaborator Author

Honestly, it's probably fine to just not export the constructors from the main API. The internal modules are internal for a reason, so you shouldn't be using those.

Which constructors do you mean? MergeTrace isn't exposed from the public API anymore, that's why I removed the exports of types that were mentioned by MergeTrace

@wenkokke
Copy link
Collaborator

wenkokke commented Jun 3, 2025

Honestly, it's probably fine to just not export the constructors from the main API. The internal modules are internal for a reason, so you shouldn't be using those.

Which constructors do you mean? MergeTrace isn't exposed from the public API anymore, that's why I removed the exports of types that were mentioned by MergeTrace

I meant, instead of having a debug flag, just to not export the constructors.

@jorisdral
Copy link
Collaborator Author

That could be a valid alternative, but I'd rather use the current approach and just not have the traces in release builds. Ideally we'd revisit merge traces later when we start comparing the real implementation and prototype

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants