cardano ping implemented with ouroboros-network #5205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
force-pushed
the
coot/cardano-ping
branch
2 times, most recently
from
531dbf6 to
9c8c962
Compare
coot
force-pushed
the
coot/cardano-ping
branch
from
9c8c962 to
150e48d
Compare
coot
force-pushed
the
coot/cardano-ping
branch
from
150e48d to
76feda7
Compare
coot
force-pushed
the
coot/cardano-ping
branch
2 times, most recently
from
8ab0ea9 to
3d9de76
Compare
coot
force-pushed
the
coot/packages
branch
2 times, most recently
from
487ab4a to
f7850ac
Compare
coot
force-pushed
the
coot/cardano-ping
branch
from
3d9de76 to
1425b60
Compare
karknu
reviewed
Oct 16, 2025
| }] | ||
| race_ (Mx.run mx bearer) | ||
| (Mx.runMiniProtocol mx | ||
| NodeToNode.chainSyncMiniProtocolNum |
There was a problem hiding this comment.
It looks like you're using the wrong miniprotocol number here when running over NodeToClient.
7 tasks
karknu
reviewed
Oct 16, 2025
| -> TDigest 5 | ||
| -> KeepAlive.Cookie | ||
| -> KeepAliveClient IO () | ||
| keepAliveClient stdout peerName logFormat td0 cookie0 = |
There was a problem hiding this comment.
There is a -c option for specifying how many keepAlive messages should be sent.
After that cardano-ping sends keepAliveDone and shuts down the connection cleanly.
You should implement that logic here.
Even though it's not implemented using `cardano-diffusion`, we often need to release it together with `cardano-diffusion`.
The instantiation of `ChainSync` is polymorphic enough to support both protocols.
We used to need to call `cborTermVersionDataCodec` to get `VersionDataCodec` from `CodecCBORTerm`. The `VersionDataCodec` and `cborTermVersionDataCodec` is moved to `ouroboros-network:api` library (`Ouroboros.network.CodecCBORTerm` module). `cardano-diffusion` provides both `nodeToNodeVersionDataCodec` and `nodeToClientVersionDataCodec`. This required a refactorisation in tests to get rid of some newtype wrappers, however the semantics of all the tests is preserved.
The tests started to fail due to usage of version data codec which doesn't satisfy round robin property on invalid version data in the previous commit.
Exposed `nodeTo{Node,Client}VersionDataCodec` instead.
coot
force-pushed
the
coot/cardano-ping
branch
from
1425b60 to
06bc667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rationale
This PR re-implements the ping command using
cardano-diffusionand moves itto
cardano-diffusionpackage aspingsublibrary. The library will notrequire changes when new node-to-{node,client} protocol versions are added, and
as a part of
cardano-diffusionit will be always released in lock withcardano-diffusionandouroboros-network. This should make it easier tomaintain it.
Requires: #5200
Checklist
Quality
Maintenance
ouroboros-networkproject.