-
Notifications
You must be signed in to change notification settings - Fork 502
Apply fourmolu to the codebase #7417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6fbfe64 to
5d7b8eb
Compare
|
SeungheonOh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few observations.
plutus-core/untyped-plutus-core/src/UntypedPlutusCore/Evaluation/Machine/Cek/Internal.hs
Outdated
Show resolved
Hide resolved
| -- * 'FrameApplyArg': call 'computeCek' over the context extended with 'FrameApplyFun' | ||
| -- * 'FrameApplyFun': call 'applyEvaluate' to attempt to apply the function | ||
| -- stored in the frame to an argument. | ||
| -- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think {- | ... -} is better for multiline haddock.
I think haddock-style: multi-line will do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, but note that using multi-line or multi-line-compact, the ending -} is always put on a separate newline: I'm unsure if this behaviour is preferred.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, @SeungheonOh why do you prefer {- | ...} over --| ... for multi-line haddock? I don't have a strong opinion, but I think -- | is more common.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it because I don't have to add -- on every newline.
5d7b8eb to
e0d9d49
Compare
e41a826 to
0272c81
Compare
54b193c to
e9e3efb
Compare
26e651e to
c60f30d
Compare
cardano-constitution/src/Cardano/Constitution/Data/Validator.hs
Outdated
Show resolved
Hide resolved
|
I don't have objections to using fourmolu, there's a few things that I haven't seen often, such as |
c60f30d to
45debdf
Compare
45debdf to
a1f703a
Compare
a1f703a to
099f3c8
Compare
099f3c8 to
0f23ec2
Compare
58d5712 to
b61208f
Compare
Our custom fork of fourmolu has the following behaviours which are different than upstream:
Multi-line Haddock has the closing
-}on the last line, not on a separate newline.-->
No space before
|or^in multiline haddock:-->
No newline between comments and haddock
-->